diff mbox

[dpdk-dev] net/avf: fix link autoneg value

Message ID 20180309175631.242976-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit March 9, 2018, 5:56 p.m. UTC 
  Intention of the logic is:
If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG

ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;

Current logic is broken, fix it according above values.

Fixes: 48de41ca11f0 ("net/avf: enable link status update")
Cc: jingjing.wu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang March 28, 2018, 6:42 a.m. UTC | #1 
Hi Ferruh:

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Saturday, March 10, 2018 1:57 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
> 
> Intention of the logic is:
> If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
> ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
> 
> ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
> 
> Current logic is broken, fix it according above values.
> 
> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> Cc: jingjing.wu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

BTW, I saw the same issue on i40evf, will you also fix that?

Thanks
Qi
Ferruh Yigit March 28, 2018, 1:25 p.m. UTC | #2 
On 3/28/2018 7:42 AM, Zhang, Qi Z wrote:
> Hi Ferruh:
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Saturday, March 10, 2018 1:57 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
>>
>> Intention of the logic is:
>> If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
>> ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
>>
>> ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
>>
>> Current logic is broken, fix it according above values.
>>
>> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
>> Cc: jingjing.wu@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> BTW, I saw the same issue on i40evf, will you also fix that?

It is in: https://dpdk.org/dev/patchwork/patch/36076/

> 
> Thanks
> Qi
>
Zhang, Helin March 29, 2018, 5:51 a.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Wednesday, March 28, 2018 2:43 PM
> To: Yigit, Ferruh; Wu, Jingjing; Lu, Wenzhuo
> Cc: dev@dpdk.org; Yigit, Ferruh; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
> 
> Hi Ferruh:
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> > Sent: Saturday, March 10, 2018 1:57 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>
> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
> >
> > Intention of the logic is:
> > If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
> > ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
> >
> > ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
> >
> > Current logic is broken, fix it according above values.
> >
> > Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> > Cc: jingjing.wu@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin
diff mbox

Patch

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 4df661705..4442c3cd8 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -608,7 +608,7 @@  avf_dev_link_update(struct rte_eth_dev *dev,
 	new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
 	new_link.link_status = vf->link_up ? ETH_LINK_UP :
 					     ETH_LINK_DOWN;
-	new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds &
+	new_link.link_autoneg = !(dev->data->dev_conf.link_speeds &
 				ETH_LINK_SPEED_FIXED);
 
 	if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,