[dpdk-dev] net/dpaa: prefer defines for link speed values
Checks
Commit Message
Use existing defines instead of hardcoded vales.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, March 9, 2018 11:29 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
> <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH] net/dpaa: prefer defines for link speed values
>
> Use existing defines instead of hardcoded vales.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
On 3/12/2018 5:28 AM, Shreyansh Jain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Friday, March 9, 2018 11:29 PM
>> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
>> <shreyansh.jain@nxp.com>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] net/dpaa: prefer defines for link speed values
>>
>> Use existing defines instead of hardcoded vales.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>
> Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
Applied to dpdk-next-net/master, thanks.
@@ -275,9 +275,9 @@ static int dpaa_eth_link_update(struct rte_eth_dev *dev,
PMD_INIT_FUNC_TRACE();
if (dpaa_intf->fif->mac_type == fman_mac_1g)
- link->link_speed = 1000;
+ link->link_speed = ETH_SPEED_NUM_1G;
else if (dpaa_intf->fif->mac_type == fman_mac_10g)
- link->link_speed = 10000;
+ link->link_speed = ETH_SPEED_NUM_10G;
else
DPAA_PMD_ERR("invalid link_speed: %s, %d",
dpaa_intf->name, dpaa_intf->fif->mac_type);