From patchwork Mon Mar 12 15:05:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 35985 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CD365F6E; Mon, 12 Mar 2018 16:05:34 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 58D0C5F57 for ; Mon, 12 Mar 2018 16:05:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 08:05:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,461,1515484800"; d="scan'208";a="33168398" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by FMSMGA003.fm.intel.com with ESMTP; 12 Mar 2018 08:05:29 -0700 From: Ferruh Yigit To: Wenzhuo Lu , Jingjing Wu Cc: dev@dpdk.org, Ferruh Yigit , Shahaf Shuler , Yongseok Koh Date: Mon, 12 Mar 2018 15:05:23 +0000 Message-Id: <20180312150523.74621-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180306162822.61791-1-ferruh.yigit@intel.com> References: <20180306162822.61791-1-ferruh.yigit@intel.com> Subject: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Which per port offloads are enabled is not clear. Printing offloads values at forwarding start. CRC strip offload value was printed in more verbose manner, it is removed since Rx/Tx offload values covers it and printing only CRC one can cause confusion. Hexadecimal offloads values are not very user friendly but preferred to not create to much noise during forwarding start. Signed-off-by: Ferruh Yigit Acked-by: Yongseok Koh --- Cc: Shahaf Shuler Cc: Yongseok Koh v2: * Add Rxq and Txq stats too * Split Rx an Tx related logs and place them related group --- app/test-pmd/config.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 4bb255c62..6249b19bb 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1682,10 +1682,6 @@ rxtx_config_display(void) struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf; printf(" port %d:\n", (unsigned int)pid); - printf(" CRC stripping %s\n", - (ports[pid].dev_conf.rxmode.offloads & - DEV_RX_OFFLOAD_CRC_STRIP) ? - "enabled" : "disabled"); printf(" RX queues=%d - RX desc=%d - RX free threshold=%d\n", nb_rxq, nb_rxd, rx_conf->rx_free_thresh); printf(" RX threshold registers: pthresh=%d hthresh=%d " @@ -1693,6 +1689,9 @@ rxtx_config_display(void) rx_conf->rx_thresh.pthresh, rx_conf->rx_thresh.hthresh, rx_conf->rx_thresh.wthresh); + printf(" Rx offloads=0x%"PRIx64" RXQ Offloads=0x%"PRIx64"\n", + ports[pid].dev_conf.rxmode.offloads, + rx_conf->offloads); printf(" TX queues=%d - TX desc=%d - TX free threshold=%d\n", nb_txq, nb_txd, tx_conf->tx_free_thresh); printf(" TX threshold registers: pthresh=%d hthresh=%d " @@ -1700,8 +1699,10 @@ rxtx_config_display(void) tx_conf->tx_thresh.pthresh, tx_conf->tx_thresh.hthresh, tx_conf->tx_thresh.wthresh); - printf(" TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n", - tx_conf->tx_rs_thresh, tx_conf->offloads); + printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh); + printf(" Tx Offloads=0x%"PRIx64" TXQ offloads=0x%"PRIx64"\n", + ports[pid].dev_conf.txmode.offloads, + tx_conf->offloads); } }