From patchwork Mon Mar 12 19:31:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 36035 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EC895B32; Mon, 12 Mar 2018 20:31:45 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 785392C58; Mon, 12 Mar 2018 20:31:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 12:31:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,462,1515484800"; d="scan'208";a="41334859" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by orsmga002.jf.intel.com with ESMTP; 12 Mar 2018 12:31:41 -0700 From: Ferruh Yigit To: Pascal Mazon Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Mon, 12 Mar 2018 19:31:33 +0000 Message-Id: <20180312193134.219899-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/tap: fix icc build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" build error: .../dpdk/drivers/net/tap/rte_eth_tap.c(598): error #279: controlling expression is constant RTE_ASSERT(!"unsupported request type: must not happen"); Although RTE_ASSERT helps debugging this issue when assert enabled, constant expression in assert means this path can be taken during runtime and there is no protection against it when assert is disabled. Adding error log and error return back, replacing RTE_ASSERT. Fixes: 7748a4b44196 ("net/tap: add debug messages") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index f09db0ea9..4bf2d9618 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -593,7 +593,9 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request, case SIOCSIFMTU: break; default: - RTE_ASSERT(!"unsupported request type: must not happen"); + RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + pmd->name); + return -EINVAL; } if (ioctl(pmd->ioctl_sock, request, ifr) < 0) goto error;