[dpdk-dev] pci: remove duplicated symbol from map file

Message ID 20180315164854.101533-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit March 15, 2018, 4:48 p.m. UTC
  Remove duplicated symbol rte_pci_device_name from .map file.

Also sort the map file to be able to detect any possible duplication
easier in the future.

Fixes: 0e3ef055bee5 ("pci: fix namespace prefix of new functions")
Cc: stable@dpdk.org

Cc: gaetan.rivet@6wind.com
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_pci/rte_pci_version.map | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
  

Comments

Gaëtan Rivet March 15, 2018, 5:21 p.m. UTC | #1
Hi Ferruh,

On Thu, Mar 15, 2018 at 04:48:54PM +0000, Ferruh Yigit wrote:
> Remove duplicated symbol rte_pci_device_name from .map file.
> 
> Also sort the map file to be able to detect any possible duplication
> easier in the future.
> 
> Fixes: 0e3ef055bee5 ("pci: fix namespace prefix of new functions")
> Cc: stable@dpdk.org
> 

Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_pci/rte_pci_version.map | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_pci/rte_pci_version.map b/lib/librte_pci/rte_pci_version.map
> index 15d93d95c..c0280277b 100644
> --- a/lib/librte_pci/rte_pci_version.map
> +++ b/lib/librte_pci/rte_pci_version.map
> @@ -3,12 +3,11 @@ DPDK_17.11 {
>  
>  	eal_parse_pci_BDF;
>  	eal_parse_pci_DomBDF;
> -	rte_pci_addr_cmp;
> -	rte_pci_addr_parse;
> -	rte_pci_device_name;
>  	pci_map_resource;
>  	pci_unmap_resource;
>  	rte_eal_compare_pci_addr;
> +	rte_pci_addr_cmp;
> +	rte_pci_addr_parse;
>  	rte_pci_device_name;
>  
>  	local: *;
> -- 
> 2.13.6
>
  
Thomas Monjalon March 22, 2018, 4:35 p.m. UTC | #2
15/03/2018 18:21, Gaëtan Rivet:
> Hi Ferruh,
> 
> On Thu, Mar 15, 2018 at 04:48:54PM +0000, Ferruh Yigit wrote:
> > Remove duplicated symbol rte_pci_device_name from .map file.
> > 
> > Also sort the map file to be able to detect any possible duplication
> > easier in the future.
> > 
> > Fixes: 0e3ef055bee5 ("pci: fix namespace prefix of new functions")
> > Cc: stable@dpdk.org
> > 
> 
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_pci/rte_pci_version.map b/lib/librte_pci/rte_pci_version.map
index 15d93d95c..c0280277b 100644
--- a/lib/librte_pci/rte_pci_version.map
+++ b/lib/librte_pci/rte_pci_version.map
@@ -3,12 +3,11 @@  DPDK_17.11 {
 
 	eal_parse_pci_BDF;
 	eal_parse_pci_DomBDF;
-	rte_pci_addr_cmp;
-	rte_pci_addr_parse;
-	rte_pci_device_name;
 	pci_map_resource;
 	pci_unmap_resource;
 	rte_eal_compare_pci_addr;
+	rte_pci_addr_cmp;
+	rte_pci_addr_parse;
 	rte_pci_device_name;
 
 	local: *;