diff mbox

[dpdk-dev] ethdev: remove unused struct forward declaration

Message ID 20180316111450.299132-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit March 16, 2018, 11:14 a.m. UTC 
  Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_ether/rte_ethdev.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Shreyansh Jain March 16, 2018, 2:09 p.m. UTC | #1 
On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_ether/rte_ethdev.h | 2 --
>  1 file changed, 2 deletions(-)
>

With movement to rte_ethdev_core.h, this looks correct.

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Ferruh Yigit March 16, 2018, 2:29 p.m. UTC | #2 
On 3/16/2018 2:09 PM, Shreyansh Jain wrote:
> On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  lib/librte_ether/rte_ethdev.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
> 
> With movement to rte_ethdev_core.h, this looks correct.

Good idea to add:

Fixes: 331c447ad913 ("ethdev: separate internal structures into own header")
Cc: ferruh.yigit@intel.com

> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>
Ferruh Yigit March 27, 2018, 6:35 p.m. UTC | #3 
On 3/16/2018 2:29 PM, Ferruh Yigit wrote:
> On 3/16/2018 2:09 PM, Shreyansh Jain wrote:
>> On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>  lib/librte_ether/rte_ethdev.h | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>
>> With movement to rte_ethdev_core.h, this looks correct.
> 
> Good idea to add:
> 
> Fixes: 331c447ad913 ("ethdev: separate internal structures into own header")
> Cc: ferruh.yigit@intel.com
> 
>>
>> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index d58b0cb02..71c3d29a4 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1117,8 +1117,6 @@  struct rte_eth_dcb_info {
 #define RTE_ETH_QUEUE_STATE_STOPPED 0
 #define RTE_ETH_QUEUE_STATE_STARTED 1
 
-struct rte_eth_dev;
-
 #define RTE_ETH_ALL RTE_MAX_ETHPORTS
 
 /* Macros to check for valid port */