From patchwork Mon Mar 19 17:52:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 36281 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84F851B295; Mon, 19 Mar 2018 18:52:18 +0100 (CET) Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 5C9871B1EE for ; Mon, 19 Mar 2018 18:52:17 +0100 (CET) Received: by mail-pl0-f65.google.com with SMTP id u11-v6so7035002plq.1 for ; Mon, 19 Mar 2018 10:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cttd0J7J5MCB4YHk1HTiTUncXpfy5dzQ/XJlO1xDBCI=; b=aCK7DF4lmSDDIUZfvJvskYd8nEACTJsASeNVZbDRa8zVqK750Nf6xEofRZ2tEzwOY+ KWOYWvkncmz5rBvVYotf8wvrGdgBKY+WCSCQFs8PDQnIKicYkl014vrb+TfOfAvBujUw pBYMAKmkRdlbARJ3+HgHouRpStVtO16XFVoJu6Yx1ECQjU1SYZKSDO6Nbrrbb343KOyu NjRUn/z6hs1w9KjlXlYnwCE653FdYEkW9tMzohDiX52MwQ/B9b4LQCdyYEN3Tt44HVK8 hO2SbEmYvUDl86CbAdX3rEzImQB58ApNOJTxfEKN17m1zPq0UxT0MeyL54ZfnpeLDWYV freQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Cttd0J7J5MCB4YHk1HTiTUncXpfy5dzQ/XJlO1xDBCI=; b=HLcF0RhSs9skLFoBpdyK6hVNz2iSrxaSoqGS2mJSELF1Xgl65WHQjq1MldNuz97YH3 /AH+nkFi6usOrFekLr40Ct5NswCgBjlmkE6axvArIu0PBG8Q+fti5d4mcIMXOiICHLo5 uR7g6W8falj79SlI1F6gy8j+Qjheq79sH+recdopq9Ikdg+7lCPiz9xS91zyFYhxx6Dr QmRA29PE4DYGyMoQ+R6wABcoqjVIpoSBMdb0iI2fGbtr5iUwjW3hFeaFOknwM1ehRtag dtS6BiVdWheiF2RZwaqru3I+BAPJ1fab0jHhqdw/opOrZTI0egELhrBPzmtri5u2Q0vh LqZw== X-Gm-Message-State: AElRT7GdyD1BjF/oLCFds0IwWx9j9VoCyZubAZB3HLF6633tzkoW1wxK 3SyeryRU+9+zZgDXzlyLslCfWo//jUQ= X-Google-Smtp-Source: AG47ELtU3enDGwkIBxKrLDjF3mViYfVqFYgjef/8DjWNzdiX6W6lODA9XhcsrwKWJ/FXw90O1XzHCA== X-Received: by 2002:a17:902:42a3:: with SMTP id h32-v6mr13029939pld.231.1521481936225; Mon, 19 Mar 2018 10:52:16 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id s78sm899295pfa.161.2018.03.19.10.52.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 10:52:15 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 19 Mar 2018 10:52:12 -0700 Message-Id: <20180319175213.9360-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319175213.9360-1-stephen@networkplumber.org> References: <20180319175213.9360-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/2] rte_mempool: fix strncpy warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Gcc-8 discovers issue with platform_mempool_ops. rte_mbuf_pool_ops.c:26:3: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncpy(mz->addr, ops_name, strlen(ops_name)); The issue is that the size should be size in destination not source. Fixes: a3acc3144a76 ("mbuf: add pool ops selection functions") --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops.c index 48cc342002a5..661cf4fb401f 100644 --- a/lib/librte_mbuf/rte_mbuf_pool_ops.c +++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c @@ -23,7 +23,7 @@ rte_mbuf_set_platform_mempool_ops(const char *ops_name) RTE_MEMPOOL_OPS_NAMESIZE, SOCKET_ID_ANY, 0); if (mz == NULL) return -rte_errno; - strncpy(mz->addr, ops_name, strlen(ops_name)); + strncpy(mz->addr, ops_name, sizeof(mz->addr) - 1); return 0; } else if (strcmp(mz->addr, ops_name) == 0) { return 0; @@ -62,7 +62,7 @@ rte_mbuf_set_user_mempool_ops(const char *ops_name) return -rte_errno; } - strncpy(mz->addr, ops_name, strlen(ops_name)); + strncpy(mz->addr, ops_name, sizeof(mz->addr) - 1); return 0; }