From patchwork Mon Mar 19 17:52:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 36282 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 727591B3C0; Mon, 19 Mar 2018 18:52:21 +0100 (CET) Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 9D7221B2B2 for ; Mon, 19 Mar 2018 18:52:18 +0100 (CET) Received: by mail-pl0-f65.google.com with SMTP id k22-v6so9861976pls.6 for ; Mon, 19 Mar 2018 10:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NIXCqEd3Q4GmfF+ScNKHEKXpl90i1ihvsyNMyspUaj0=; b=ycoCKOE/HCoxgz0wnoJoI3F8HOvXEnCizilDPe/xSkprpi1MipTf/tFAlKdE2TSpuA K4a/PLPSpEatkuZgJ8BkrYptWEje+ICv71JIFCNyv3++MK8uryHyOkby0SMZUsX/n6bl oliwTEcZN1xiJQB0Iq4zMVH2xHYEcS3lhOSABbIa6XCR7hwMHvuc+r7yd90bpMGUQPeJ bjEiibOaqhDI67JXWwbS2D+3elRLa9ChNpq+nbZhi1jP+Aw+jM9NZtiJd/tsQ0fNqrjC QDHW+4ZkdueRhNAC6NVWnAOS41FOJdzj18MPUNLXb28bBswMKEFun3FwQahlDcYkJC6l in1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NIXCqEd3Q4GmfF+ScNKHEKXpl90i1ihvsyNMyspUaj0=; b=ruhWE8vQ/8FitOAumaTyl5BDb5IiuYpHglMGmySiVjntqzZ35q2CO1/MM5ylgCfwHN Pk4OuJtgGRuXiVLtgopdIjz9iWX2ozHgOyp1YIprObxfx3LayWdyg5Of6EGBoToYOHht psknhvD5LcjRFY7BZPZAFtDYkwG/4QbwGKd+VIWx1XOnjtbVex/EsXSDElQnQ73Dd4xy hk4lSOZkXDKMtarD6qo0F4UiFZK3U2Ry4yQpfwHKjkHKCTeel6ONV7t+91rK/ZplNqJ5 ty6anQRDf36g6j2WM0W5PKm6A9sq50E4afG9q4oCyD6NcGHSD9hWfgIjQF8SKrQ8S1VP atCw== X-Gm-Message-State: AElRT7GP3+eHFlBvZzWEH7S51Ct5DYWrob/fDf6VPlS4GlKR03uZ4Om7 oXFJJv27AjMInacIj64D9Rx4G0maVmI= X-Google-Smtp-Source: AG47ELuZWt26AXI6BAtSwCHGbCLawd20VZQmFCGcHkNzzWowZpyDvfMiGGDBqMDwPUHSYh/+i+kVvA== X-Received: by 2002:a17:902:bd09:: with SMTP id p9-v6mr13350962pls.68.1521481937574; Mon, 19 Mar 2018 10:52:17 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id s78sm899295pfa.161.2018.03.19.10.52.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 10:52:16 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 19 Mar 2018 10:52:13 -0700 Message-Id: <20180319175213.9360-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180319175213.9360-1-stephen@networkplumber.org> References: <20180319175213.9360-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/2] rte_metrics: fix strncpy truncation warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: librte_metrics/rte_metrics.c:218:4: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] strncpy(names[idx_name].name, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ stats->metadata[idx_name].name, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ RTE_METRICS_MAX_NAME_LEN); ~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Stephen Hemminger --- lib/librte_metrics/rte_metrics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index 556ae1ba8b4d..ae79d4ab276e 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -214,10 +214,13 @@ rte_metrics_get_names(struct rte_metric_name *names, rte_spinlock_unlock(&stats->lock); return return_value; } - for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) + + for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) { + memset(names[idx_name].name, 0, RTE_METRICS_MAX_NAME_LEN); strncpy(names[idx_name].name, stats->metadata[idx_name].name, - RTE_METRICS_MAX_NAME_LEN); + RTE_METRICS_MAX_NAME_LEN - 1); + } } return_value = stats->cnt_stats; rte_spinlock_unlock(&stats->lock);