diff mbox

[dpdk-dev] net/virtio-user: fix port_id type

Message ID 20180330083150.44990-1-zhiyong.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Yang, Zhiyong March 30, 2018, 8:31 a.m. UTC 
  virtio-user port_id range should be increased from 8 bits to 16 bits.

Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Coquelin March 30, 2018, 8:36 a.m. UTC | #1 
On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:
> virtio-user port_id range should be increased from 8 bits to 16 bits.
> 
> Fixes: f8244c6399d9 ("ethdev: increase port id range")

Next time, please add cc: stable@dpdk.org as it targets v17.11 LTS.

> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
> ---
>   drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
Yang, Zhiyong March 30, 2018, 8:39 a.m. UTC | #2 
> -----Original Message-----

> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]

> Sent: Friday, March 30, 2018 4:37 PM

> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org

> Cc: Bie, Tiwei <tiwei.bie@intel.com>; stable@dpdk.org

> Subject: Re: [PATCH] net/virtio-user: fix port_id type

> 

> 

> 

> On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:

> > virtio-user port_id range should be increased from 8 bits to 16 bits.

> >

> > Fixes: f8244c6399d9 ("ethdev: increase port id range")

> 

> Next time, please add cc: stable@dpdk.org as it targets v17.11 LTS.


Ok.   :)

Zhiyong
Maxime Coquelin April 4, 2018, 9:51 a.m. UTC | #3 
On 03/30/2018 10:31 AM, zhiyong.yang@intel.com wrote:
> virtio-user port_id range should be increased from 8 bits to 16 bits.
> 
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>   drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> index 64467b4f9..5f8755771 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> @@ -31,7 +31,7 @@ struct virtio_user_dev {
>   				   */
>   	uint64_t	device_features; /* supported features by device */
>   	uint8_t		status;
> -	uint8_t		port_id;
> +	uint16_t	port_id;
>   	uint8_t		mac_addr[ETHER_ADDR_LEN];
>   	char		path[PATH_MAX];
>   	struct vring	vrings[VIRTIO_MAX_VIRTQUEUES];
> 

Applied to dpdk-next-virtio/master.

Thanks!
Maxime
diff mbox

Patch

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
index 64467b4f9..5f8755771 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
@@ -31,7 +31,7 @@  struct virtio_user_dev {
 				   */
 	uint64_t	device_features; /* supported features by device */
 	uint8_t		status;
-	uint8_t		port_id;
+	uint16_t	port_id;
 	uint8_t		mac_addr[ETHER_ADDR_LEN];
 	char		path[PATH_MAX];
 	struct vring	vrings[VIRTIO_MAX_VIRTQUEUES];