From patchwork Fri Mar 30 15:16:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 36782 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AC787289; Fri, 30 Mar 2018 17:17:06 +0200 (CEST) Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 24FE54CB3 for ; Fri, 30 Mar 2018 17:17:04 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AD058182D06; Fri, 30 Mar 2018 15:17:03 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D9BC10B00A7; Fri, 30 Mar 2018 15:16:56 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, xiangxia.m.yue@gmail.com, ferruh.yigit@intel.com, thomas@monjalon.net, tredaelli@redhat.com, arybchenko@solarflare.com Cc: Maxime Coquelin Date: Fri, 30 Mar 2018 17:16:41 +0200 Message-Id: <20180330151641.20715-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 30 Mar 2018 15:17:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 30 Mar 2018 15:17:03 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, charbuf, sizeof(charbuf)); ^ lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_notify’: lib/librte_vhost/fd_man.c:324:2: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] write(fdset->u.writefd, "1", 1); ^ Reported-by: Andrew Rybchenko Signed-off-by: Tonghao Zhang Signed-off-by: Maxime Coquelin --- lib/librte_vhost/fd_man.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index ca1ba2622..1f9e22f96 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c @@ -281,7 +281,13 @@ fdset_pipe_read_cb(int readfd, void *dat __rte_unused, int *remove __rte_unused) { char charbuf[16]; - read(readfd, charbuf, sizeof(charbuf)); + int r = read(readfd, charbuf, sizeof(charbuf)); + /* + * Just an optimization, we don't care if read() failed + * so ignore explicitly its return value to make the + * compiler happy + */ + RTE_SET_USED(r); } void @@ -321,5 +327,12 @@ fdset_pipe_init(struct fdset *fdset) void fdset_pipe_notify(struct fdset *fdset) { - write(fdset->u.writefd, "1", 1); + int r = write(fdset->u.writefd, "1", 1); + /* + * Just an optimization, we don't care if read() failed + * so ignore explicitly its return value to make the + * compiler happy + */ + RTE_SET_USED(r); + }