diff mbox

[dpdk-dev] lib/librte_vhost: remove packet dump

Message ID 20180409153429.20123-2-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Fan Zhang April 9, 2018, 3:34 p.m. UTC 
  This patch removes unnecessary packet dump for debugging.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/vhost_crypto.c | 36 ------------------------------------
 1 file changed, 36 deletions(-)

Comments

Maxime Coquelin April 11, 2018, 8:47 a.m. UTC | #1 
On 04/09/2018 05:34 PM, Fan Zhang wrote:
> This patch removes unnecessary packet dump for debugging.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 36 ------------------------------------
>   1 file changed, 36 deletions(-)
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin April 11, 2018, 8:59 a.m. UTC | #2 
On 04/11/2018 10:47 AM, Maxime Coquelin wrote:
> 
> 
> On 04/09/2018 05:34 PM, Fan Zhang wrote:
>> This patch removes unnecessary packet dump for debugging.
>>
>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>>   lib/librte_vhost/vhost_crypto.c | 36 
>> ------------------------------------
>>   1 file changed, 36 deletions(-)
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime

Applied to dpdk-next-virtio/master

Thanks,
Maxime
Maxime Coquelin April 11, 2018, 2:36 p.m. UTC | #3 
On 04/11/2018 10:59 AM, Maxime Coquelin wrote:
> 
> 
> On 04/11/2018 10:47 AM, Maxime Coquelin wrote:
>>
>>
>> On 04/09/2018 05:34 PM, Fan Zhang wrote:
>>> This patch removes unnecessary packet dump for debugging.
>>>
>>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>>> ---
>>>   lib/librte_vhost/vhost_crypto.c | 36 
>>> ------------------------------------
>>>   1 file changed, 36 deletions(-)
>> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> Thanks,
>> Maxime
> 
> Applied to dpdk-next-virtio/master

Not to break bisection, I squashed the fix in offending commit.

Thanks,
Maxime
diff mbox

Patch

diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index d84513e7f..d86af0532 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -578,21 +578,12 @@  write_back_data(struct rte_crypto_op *op, struct vhost_crypto_data_req *vc_req)
 	left -= to_write;
 	src_data += to_write;
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	printf("desc addr %llu len %u:", desc->addr, desc->len);
-	rte_hexdump(stdout, "", dst, to_write);
-#endif
-
 	while ((desc->flags & VRING_DESC_F_NEXT) && left > 0) {
 		desc = &head[desc->next];
 		rte_prefetch0(&head[desc->next]);
 		to_write = RTE_MIN(desc->len, (uint32_t)left);
 		dst = GPA_TO_VVA(uint8_t *, mem, desc->addr);
 		rte_memcpy(dst, src_data, to_write);
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-		printf("desc addr %llu len %u:", desc->addr, desc->len);
-		rte_hexdump(stdout, "DST:", dst, to_write);
-#endif
 		left -= to_write;
 		src_data += to_write;
 	}
@@ -626,10 +617,6 @@  prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		goto error_exit;
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "IV:", iv_data, cipher->para.iv_len);
-#endif
-
 	m_src->data_len = cipher->para.src_data_len;
 
 	switch (vcrypto->option) {
@@ -664,11 +651,6 @@  prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		goto error_exit;
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "SRC:", rte_pktmbuf_mtod(m_src, void *),
-			cipher->para.src_data_len);
-#endif
-
 	/* dst */
 	desc = find_write_desc(head, desc);
 	if (unlikely(!desc)) {
@@ -746,9 +728,6 @@  prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		goto error_exit;
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "IV:", iv_data, chain->para.iv_len);
-#endif
 	m_src->data_len = chain->para.src_data_len;
 	m_dst->data_len = chain->para.dst_data_len;
 
@@ -782,11 +761,6 @@  prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		goto error_exit;
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "SRC:", rte_pktmbuf_mtod(m_src, void *),
-			chain->para.src_data_len);
-#endif
-
 	/* dst */
 	desc = find_write_desc(head, desc);
 	if (unlikely(!desc)) {
@@ -846,11 +820,6 @@  prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		goto error_exit;
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "Digest:", op->sym->auth.digest.data,
-			chain->para.hash_result_len);
-#endif
-
 	/* record inhdr */
 	vc_req->inhdr = get_data_ptr(head, mem, &desc, INHDR_LEN);
 	if (unlikely(vc_req->inhdr == NULL)) {
@@ -1016,11 +985,6 @@  vhost_crypto_finalize_one_request(struct rte_crypto_op *op,
 		}
 	}
 
-#ifdef RTE_LIBRTE_VHOST_DEBUG
-	rte_hexdump(stdout, "DST:", rte_pktmbuf_mtod(op->sym->m_dst, uint8_t *),
-			m_dst->data_len);
-#endif
-
 	vc_req->vq->used->ring[desc_idx].id = desc_idx;
 	vc_req->vq->used->ring[desc_idx].len = vc_req->len;