[dpdk-dev,v2,12/15] doc: update mlx5 guide on tunnel offloading

Message ID 20180410133415.189905-13-xuemingl@mellanox.com (mailing list archive)
State Superseded, archived
Delegated to: Shahaf Shuler
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Xueming Li April 10, 2018, 1:34 p.m. UTC
  Remove tunnel limitations, add new hardware tunnel offload features.

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
 doc/guides/nics/mlx5.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Nélio Laranjeiro April 11, 2018, 12:32 p.m. UTC | #1
On Tue, Apr 10, 2018 at 09:34:12PM +0800, Xueming Li wrote:
> Remove tunnel limitations, add new hardware tunnel offload features.
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  doc/guides/nics/mlx5.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index b1bab2ce2..c256f85f3 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -100,12 +100,12 @@ Features
>  - RX interrupts.
>  - Statistics query including Basic, Extended and per queue.
>  - Rx HW timestamp.
> +- Tunnel types: VXLAN, L3 VXLAN, VXLAN-GPE, GRE, MPLS-in-GRE, MPLS-in-UDP.
> +- Tunnel HW offloads: packet type, inner/outer RSS, IP and UDP checksum verification.
>  
>  Limitations
>  -----------
>  
> -- Inner RSS for VXLAN frames is not supported yet.
> -- Hardware checksum RX offloads for VXLAN inner header are not supported yet.
>  - For secondary process:
>  
>    - Forked secondary process not supported.
> -- 
> 2.13.3

Inner RSS may deserve its own entry in the features docs [1][2][3],

Thomas what do you think?

Regards,

[1] https://dpdk.org/doc/guides/nics/overview.html
[2] https://dpdk.org/browse/dpdk/tree/doc/guides/nics/features/default.ini
[3] https://dpdk.org/browse/dpdk/tree/doc/guides/nics/features/mlx5.ini
  
Thomas Monjalon April 11, 2018, 12:43 p.m. UTC | #2
11/04/2018 14:32, Nélio Laranjeiro:
> On Tue, Apr 10, 2018 at 09:34:12PM +0800, Xueming Li wrote:
> > -- Inner RSS for VXLAN frames is not supported yet.
> > -- Hardware checksum RX offloads for VXLAN inner header are not supported yet.
> >  - For secondary process:
> 
> Inner RSS may deserve its own entry in the features docs [1][2][3],
> 
> Thomas what do you think?

Yes, it looks reasonnable to add inner RSS in features list.
Ferruh, do you agree?


> [1] https://dpdk.org/doc/guides/nics/overview.html
> [2] https://dpdk.org/browse/dpdk/tree/doc/guides/nics/features/default.ini
> [3] https://dpdk.org/browse/dpdk/tree/doc/guides/nics/features/mlx5.ini
  

Patch

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index b1bab2ce2..c256f85f3 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -100,12 +100,12 @@  Features
 - RX interrupts.
 - Statistics query including Basic, Extended and per queue.
 - Rx HW timestamp.
+- Tunnel types: VXLAN, L3 VXLAN, VXLAN-GPE, GRE, MPLS-in-GRE, MPLS-in-UDP.
+- Tunnel HW offloads: packet type, inner/outer RSS, IP and UDP checksum verification.
 
 Limitations
 -----------
 
-- Inner RSS for VXLAN frames is not supported yet.
-- Hardware checksum RX offloads for VXLAN inner header are not supported yet.
 - For secondary process:
 
   - Forked secondary process not supported.