From patchwork Fri Apr 13 22:21:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 38098 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D61A51C674; Sat, 14 Apr 2018 00:21:22 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0B00E1C66C; Sat, 14 Apr 2018 00:21:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 15:21:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="41835942" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2018 15:21:17 -0700 From: Ferruh Yigit To: Harish Patil , Rasesh Mody , Rahul Lakkireddy , Wenzhuo Lu , Qi Zhang , Xiao Wang , Beilei Xing , Konstantin Ananyev , Shahed Shaikh , Andrew Rybchenko , Yong Wang Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Fri, 13 Apr 2018 23:21:09 +0100 Message-Id: <20180413222109.144181-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180413222109.144181-1-ferruh.yigit@intel.com> References: <20180312123900.22361-1-ferruh.yigit@intel.com> <20180413222109.144181-1-ferruh.yigit@intel.com> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: remove redundant icc flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ICC warning #188 already disabled globally via commit [1], no need individual arguments in PMDs. [1] Fixes: 1b80b9c854c3 ("mk: disable icc warning 188") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Tested-by: Pablo de Lara --- drivers/net/bnx2x/Makefile | 4 ---- drivers/net/cxgbe/Makefile | 8 -------- drivers/net/e1000/Makefile | 2 +- drivers/net/i40e/Makefile | 2 +- drivers/net/qede/Makefile | 1 - 5 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile index e3a39a9e0..0c0f51aaa 100644 --- a/drivers/net/bnx2x/Makefile +++ b/drivers/net/bnx2x/Makefile @@ -17,10 +17,6 @@ EXPORT_MAP := rte_pmd_bnx2x_version.map LIBABIVER := 1 -ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -CFLAGS += -diag-disable 188 #188: enumerated type mixed with another type -endif - # # all source are stored in SRCS-y # diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile index 1015fec12..79fdb6f06 100644 --- a/drivers/net/cxgbe/Makefile +++ b/drivers/net/cxgbe/Makefile @@ -18,12 +18,6 @@ EXPORT_MAP := rte_pmd_cxgbe_version.map LIBABIVER := 1 -ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -# -# CFLAGS for icc -# -CFLAGS_BASE_DRIVER = -diag-disable 188 -else # # CFLAGS for gcc/clang # @@ -32,9 +26,7 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) CFLAGS += -Wno-deprecated endif endif -CFLAGS_BASE_DRIVER = -endif LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_bus_pci diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile index 01941ac69..87cfb265d 100644 --- a/drivers/net/e1000/Makefile +++ b/drivers/net/e1000/Makefile @@ -22,7 +22,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) # # CFLAGS for icc # -CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 -diag-disable 188 +CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259 else # diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index c91545741..7e34b50a7 100644 --- a/drivers/net/i40e/Makefile +++ b/drivers/net/i40e/Makefile @@ -24,7 +24,7 @@ LIBABIVER := 2 # to disable warnings # ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) -CFLAGS_BASE_DRIVER = -diag-disable 593 -diag-disable 188 +CFLAGS_BASE_DRIVER = -diag-disable 593 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-unused-value diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index db5ba966e..831ee15df 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile @@ -73,7 +73,6 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion endif else #ICC -CFLAGS_BASE_DRIVER += -diag-disable 188 #188: enumerated type mixed with another type CFLAGS_qede_ethdev.o += -diag-disable 279 #279: controlling expression is constant endif