From patchwork Tue Apr 17 23:53:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 38386 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28A7F9605; Wed, 18 Apr 2018 01:53:36 +0200 (CEST) Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) by dpdk.org (Postfix) with ESMTP id 395388E81 for ; Wed, 18 Apr 2018 01:53:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1492; q=dns/txt; s=iport; t=1524009215; x=1525218815; h=from:to:cc:subject:date:message-id; bh=N6t5sb0wGVncZk1YQrKLQqBxLTy2BxY510oS4NlJ4dQ=; b=Ex11ojKlD92SvaTYOTlyUEuSDeONxqe8f9zTeX9B/z2CZ3Nkh1Ai2knU R5dm/Cy15sDPRRsXSje5fCjIynkEQ7jocQBY9z6rX3dDk9nxV48YRH3/y f4YuqgsmiKl/rL7wD5SmSXMYnM6GbiXRb0+a1cQe61cqLR3g+rSWdo5xY w=; X-IronPort-AV: E=Sophos;i="5.48,464,1517875200"; d="scan'208";a="379743505" Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 23:53:34 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id w3HNrXOn018706; Tue, 17 Apr 2018 23:53:34 GMT Received: by cisco.com (Postfix, from userid 392789) id D8A4A20F2001; Tue, 17 Apr 2018 16:53:33 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, John Daley Date: Tue, 17 Apr 2018 16:53:24 -0700 Message-Id: <20180417235324.25315-1-johndale@cisco.com> X-Mailer: git-send-email 2.16.2 Subject: [dpdk-dev] [PATCH] net/enic: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A local variable was used without initialization and triggered a coverity issue. Is is fixed here, but there is no ill effect of not initializing the variable in this case. 'rxq_interupt_offset' is irrelevant if 'rxq_interrupt_enable' is not set (the condition caught by coverity). Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages") Coverity issue: 268314 Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 822037ce8..2a2269794 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -200,15 +200,14 @@ void enic_init_vnic_resources(struct enic *enic) unsigned int error_interrupt_enable = 1; unsigned int error_interrupt_offset = 0; unsigned int rxq_interrupt_enable = 0; - unsigned int rxq_interrupt_offset; + unsigned int rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; unsigned int index = 0; unsigned int cq_idx; struct vnic_rq *data_rq; - if (enic->rte_dev->data->dev_conf.intr_conf.rxq) { + if (enic->rte_dev->data->dev_conf.intr_conf.rxq) rxq_interrupt_enable = 1; - rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; - } + for (index = 0; index < enic->rq_count; index++) { cq_idx = enic_cq_rq(enic, enic_rte_rq_idx_to_sop_idx(index));