From patchwork Tue Apr 24 16:58:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 38832 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E777C2C18; Tue, 24 Apr 2018 18:58:21 +0200 (CEST) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id B02BD4C90 for ; Tue, 24 Apr 2018 18:58:15 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id h69so12764614pfe.13 for ; Tue, 24 Apr 2018 09:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fGdn2l3w4qxIiPDFu359FcAzfn9XQtlbeiKy0QQ7bs8=; b=XL3KxnD8swIgbsKAkyMb+lImcPyic9uxcMs18sFDbJOgPhGWEAPfJguvxIXFr3VK0R gOXBz61N+foa0seQKSweloiWo3IILFKy5wYtHr69twpEKUgOb4klif5btVje6bphQbH1 lsTH6npbUdJl3oCmTbBt0uU93VPPlNdOlQ/WVLh/Xl2Y+xnGBIp2SA6WWUtfWr72Z5Mv XAmyHtDmUL7/juZ1dlDYMKmfoc7b+rAdBtxgPpGqys+nxlRMgD/Ghg6C8oLOOVB2R7M8 yjw3rb64vm+8BHLyezhOmqTB+KltoWCmRTNy9SFJee0CnYLHY8AnaJFXoSmlv0Pzknc6 26Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fGdn2l3w4qxIiPDFu359FcAzfn9XQtlbeiKy0QQ7bs8=; b=etNZ1IrV+jZaqacy1YyYLO94uaAzZN9BAf+qC26wgzI7vbFb4bYTqpN+TX+fBUCzul Rqo8qL6hfoAz5zwBAhy9Ud1KueN4+4cSoTY4hZl2JuU2RKgsatXMGkZnhPorqfzyCgi9 ibN1udbqyjz1IpKVpBk6c6CK6bluDdILx/L1yxEIXU3dnXJoxT4Iupwxc9euN38UadnV b1RaFxkTISC/TWAmE6Hpm8/Uuh/ZMg7d6bbCovehAD9OPi+VoD4xdmbLD4ThP3t+BGXR GNYd2UGf+uA37W1fzG/L7bvULUN8zcZ/3uzXdq4OmC7WEk0rbA2a6CgiwhGAI89stzDM tpbA== X-Gm-Message-State: ALQs6tAiQLLRcE9e+/I/LO88HJ7MzciDgZJ27KxUp+ToNuGD+LvEM8Ip Qa2Z+y+4AE2QqI/zUTE9kmoYQcvjeHE= X-Google-Smtp-Source: AIpwx4/LGwM3Yc/Q+lDpY1A3+QUN139Pv39/saipt3XI8HK1qGFLpL6bKdyJQU8bnkWLcu3rSImOSA== X-Received: by 10.98.245.139 with SMTP id b11mr24419895pfm.113.1524589094429; Tue, 24 Apr 2018 09:58:14 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id a28sm19851114pfl.86.2018.04.24.09.58.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 09:58:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 24 Apr 2018 09:58:05 -0700 Message-Id: <20180424165808.23292-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180424165808.23292-1-stephen@networkplumber.org> References: <20180424165808.23292-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH v2 2/5] eal: allow symbolic log levels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Much easeier to remember names than numbers. Allows --log-level=pmd.net.ixgbe.*,debug Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 67 ++++++++++++++++------ 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 0e6adcb9ddb5..13c05bbe9b70 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -917,10 +917,49 @@ eal_parse_syslog(const char *facility, struct internal_config *conf) } static int -eal_parse_log_level(const char *arg) +eal_parse_log_priority(const char *level) { - char *end, *str, *type, *level; + static const char * const levels[] = { + [RTE_LOG_EMERG] = "emergency", + [RTE_LOG_ALERT] = "alert", + [RTE_LOG_CRIT] = "critical", + [RTE_LOG_ERR] = "error", + [RTE_LOG_WARNING] = "warning", + [RTE_LOG_NOTICE] = "notice", + [RTE_LOG_INFO] = "info", + [RTE_LOG_DEBUG] = "debug", + }; + size_t len = strlen(level); unsigned long tmp; + char *end; + unsigned int i; + + if (len == 0) + return -1; + + /* look for named values, skip 0 which is not a valid level */ + for (i = 1; i < RTE_DIM(levels); i++) { + if (strncmp(levels[i], level, len) == 0) + return i; + } + + /* not a string, maybe it is numeric */ + errno = 0; + tmp = strtoul(level, &end, 0); + + /* check for errors */ + if (errno != 0 || end == NULL || *end != '\0' || + tmp >= UINT32_MAX) + return -1; + + return tmp; +} + +static int +eal_parse_log_level(const char *arg) +{ + char *str, *type, *level; + int priority; str = strdup(arg); if (str == NULL) @@ -934,23 +973,17 @@ eal_parse_log_level(const char *arg) level = strsep(&str, ","); } - errno = 0; - tmp = strtoul(level, &end, 0); - - /* check for errors */ - if ((errno != 0) || (level[0] == '\0') || - end == NULL || (*end != '\0')) - goto fail; - - /* log_level is a uint32_t */ - if (tmp >= UINT32_MAX) + priority = eal_parse_log_priority(level); + if (priority < 0) { + fprintf(stderr, "invalid log priority: %s\n", level); goto fail; + } if (type == NULL) { - rte_log_set_global_level(tmp); - } else if (rte_log_set_level_regexp(type, tmp) < 0) { - printf("cannot set log level %s,%lu\n", - type, tmp); + rte_log_set_global_level(priority); + } else if (rte_log_set_level_regexp(type, priority) < 0) { + fprintf(stderr, "cannot set log level %s,%d\n", + type, priority); goto fail; } else { struct rte_eal_opt_loglevel *opt_ll; @@ -972,7 +1005,7 @@ eal_parse_log_level(const char *arg) goto fail; } - opt_ll->level = tmp; + opt_ll->level = priority; TAILQ_INSERT_HEAD(&opt_loglevel_list, opt_ll, next); }