[dpdk-dev,2/2] net/mlx4: fix useless default in RSS converter
Checks
Commit Message
Since the commit below, mlx4_conv_rss_types() does not need to support
special value -1 anymore. Other functions rely on priv->hw_rss_sup
directly.
Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields")
Cc: stable@dpdk.org
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx4/mlx4_flow.c | 5 -----
1 file changed, 5 deletions(-)
Comments
On 5/4/2018 4:17 PM, Adrien Mazarguil wrote:
> Since the commit below, mlx4_conv_rss_types() does not need to support
> special value -1 anymore. Other functions rely on priv->hw_rss_sup
> directly.
>
> Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
This patch dropped from next-net as requested by Shahaf. So won't be on rc3.
@@ -78,9 +78,6 @@ struct mlx4_drop {
/**
* Convert DPDK RSS hash types to their Verbs equivalent.
*
- * This function returns the supported (default) set when @p types has
- * special value (uint64_t)-1.
- *
* @param priv
* Pointer to private structure.
* @param types
@@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t types)
uint64_t conv = 0;
unsigned int i;
- if (types == (uint64_t)-1)
- return priv->hw_rss_sup;
for (i = 0; i != RTE_DIM(in); ++i)
if (types & in[i]) {
seen |= types & in[i];