From patchwork Fri Sep 28 01:58:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 45539 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0C521B156; Fri, 28 Sep 2018 03:58:40 +0200 (CEST) Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id CDF521B148; Fri, 28 Sep 2018 03:58:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1108; q=dns/txt; s=iport; t=1538099919; x=1539309519; h=from:to:cc:subject:date:message-id; bh=KmHI+4FaYizkIPTtjtVepSjsmhTi8MNG8l0tb8Ds+C0=; b=jd/Re4kcId7nXoBE0VmBRmOH/FD6h815iEC/Y5tvBwznwQaF0nmu+Kt8 yAgU283//gCPObIPRXszsIxYFPwcJGwfi1dezSiZ0kZAhp0CJaML+Q2bd R/fZn6JRdYs8YjSt3ZK/Nyp3djqPbQ/s7dHb/ddILxNt9psAziJ1dab97 s=; X-IronPort-AV: E=Sophos;i="5.54,313,1534809600"; d="scan'208";a="177276876" Received: from alln-core-4.cisco.com ([173.36.13.137]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 01:58:37 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id w8S1wbQr016805; Fri, 28 Sep 2018 01:58:37 GMT Received: by cisco.com (Postfix, from userid 392789) id 3A67420F2001; Thu, 27 Sep 2018 18:58:37 -0700 (PDT) From: John Daley To: ferruh.yigit@intel.com Cc: dev@dpdk.org, John Daley , stable@dpdk.org, Hyong Youb Kim Date: Thu, 27 Sep 2018 18:58:25 -0700 Message-Id: <20180928015827.25786-1-johndale@cisco.com> X-Mailer: git-send-email 2.16.2 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-core-4.cisco.com Subject: [dpdk-dev] [PATCH 1/3] net/enic: fix flow API memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_flow structures were not being freed when destroyed or flushed. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: stable@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c index 0cf04aefd..9b612f1d5 100644 --- a/drivers/net/enic/enic_flow.c +++ b/drivers/net/enic/enic_flow.c @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, enic_flow_del_filter(enic, flow->enic_filter_id, error); LIST_REMOVE(flow, next); rte_spinlock_unlock(&enic->flows_lock); + rte_free(flow); return 0; } @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error) flow = LIST_FIRST(&enic->flows); enic_flow_del_filter(enic, flow->enic_filter_id, error); LIST_REMOVE(flow, next); + rte_free(flow); } rte_spinlock_unlock(&enic->flows_lock); return 0;