diff mbox series

[v1] test/rcu: remove redundant header file

Message ID 20190724032538.45318-1-ruifeng.wang@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] test/rcu: remove redundant header file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ruifeng Wang July 24, 2019, 3:25 a.m. UTC 
  RCU library now includes stdbool.h header itself.
There is no need to include this header file in RCU user files.

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 app/test/test_rcu_qsbr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Honnappa Nagarahalli July 24, 2019, 6:01 p.m. UTC | #1 
> 
> RCU library now includes stdbool.h header itself.
> There is no need to include this header file in RCU user files.
> 
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  app/test/test_rcu_qsbr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> 1d273e39d..d1b9e46a2 100644
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> @@ -3,7 +3,6 @@
>   */
> 
>  #include <stdio.h>
> -#include <stdbool.h>
>  #include <rte_pause.h>
>  #include <rte_rcu_qsbr.h>
>  #include <rte_hash.h>
> --
> 2.17.1

Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Thomas Monjalon July 30, 2019, 9:30 a.m. UTC | #2 
24/07/2019 20:01, Honnappa Nagarahalli:
> > 
> > RCU library now includes stdbool.h header itself.
> > There is no need to include this header file in RCU user files.
> > 
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> 
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Applied, thanks
diff mbox series

Patch

diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c
index 1d273e39d..d1b9e46a2 100644
--- a/app/test/test_rcu_qsbr.c
+++ b/app/test/test_rcu_qsbr.c
@@ -3,7 +3,6 @@ 
  */
 
 #include <stdio.h>
-#include <stdbool.h>
 #include <rte_pause.h>
 #include <rte_rcu_qsbr.h>
 #include <rte_hash.h>