diff mbox series

[v2,1/2] lib: fix log typos

Message ID 20191113161015.9736-1-ktraynor@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [v2,1/2] lib: fix log typos |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Kevin Traynor Nov. 13, 2019, 4:10 p.m. UTC 
  Fix these as they are user visible. Found with codespell.

Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
Fixes: 445c6528b55f ("power: common interface for guest and host")
Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

---
v2: fix checkpatch fail

Cc: anatoly.burakov@intel.com
Cc: david.hunt@intel.com
Cc: maxime.coquelin@redhat.com
Cc: tiwei.bie@intel.com
Cc: zhihong.wang@intel.com
Cc: jianfeng.tan@intel.com
Cc: shahafs@mellanox.com
Cc: alan.carew@intel.com
Cc: liang.j.ma@intel.com
---
 lib/librte_eal/common/eal_common_proc.c | 4 ++--
 lib/librte_eal/linux/eal/eal_vfio.c     | 4 ++--
 lib/librte_power/power_acpi_cpufreq.c   | 4 ++--
 lib/librte_power/power_pstate_cpufreq.c | 6 +++---
 lib/librte_vhost/socket.c               | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

Comments

David Marchand Nov. 19, 2019, 9:18 p.m. UTC | #1 
On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> Fix these as they are user visible. Found with codespell.
>
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
> Fixes: 445c6528b55f ("power: common interface for guest and host")
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

For the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>

It would be nice to have codespell in devtools/checkpatches.sh.

Applied, thanks.


--
David Marchand
Kevin Traynor Nov. 19, 2019, 9:56 p.m. UTC | #2 
On 19/11/2019 21:18, David Marchand wrote:
> On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>
>> Fix these as they are user visible. Found with codespell.
>>
>> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
>> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
>> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
>> Fixes: 445c6528b55f ("power: common interface for guest and host")
>> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> For the series,
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> It would be nice to have codespell in devtools/checkpatches.sh.
> 

Voila!
https://git.dpdk.org/dpdk/commit/devtools/checkpatches.sh?id=abdd314151b304eeab08528555e884544151a2e4

Maybe we should add some doc to the contributors guide for it. It seems
to be run by one of the robots anyway.

> Applied, thanks.
> 
> 
> --
> David Marchand
>
David Marchand Nov. 20, 2019, 8 a.m. UTC | #3 
On Tue, Nov 19, 2019 at 10:56 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> On 19/11/2019 21:18, David Marchand wrote:
> > On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> >>
> >> Fix these as they are user visible. Found with codespell.
> >>
> >> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> >> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
> >> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
> >> Fixes: 445c6528b55f ("power: common interface for guest and host")
> >> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> >> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> >
> > For the series,
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> >
> > It would be nice to have codespell in devtools/checkpatches.sh.
> >
>
> Voila!

"Voilà !" :-)

> https://git.dpdk.org/dpdk/commit/devtools/checkpatches.sh?id=abdd314151b304eeab08528555e884544151a2e4

Arf, right.


> Maybe we should add some doc to the contributors guide for it. It seems
> to be run by one of the robots anyway.

It is enabled by default.

It does catch "informations".

But it does not pick, for example, my typo on "preferrence" (no
excuse, in French, it takes only one r too).

Did you use https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary.txt
?
Not sure the robots are using the latest version.


--
David Marchand
Kevin Traynor Nov. 20, 2019, 1:29 p.m. UTC | #4 
On 20/11/2019 08:00, David Marchand wrote:
> On Tue, Nov 19, 2019 at 10:56 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>
>> On 19/11/2019 21:18, David Marchand wrote:
>>> On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>>>
>>>> Fix these as they are user visible. Found with codespell.
>>>>
>>>> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
>>>> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
>>>> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped")
>>>> Fixes: 445c6528b55f ("power: common interface for guest and host")
>>>> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>>>
>>> For the series,
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>>
>>> It would be nice to have codespell in devtools/checkpatches.sh.
>>>
>>
>> Voila!
> 
> "Voilà !" :-)
> 
>> https://git.dpdk.org/dpdk/commit/devtools/checkpatches.sh?id=abdd314151b304eeab08528555e884544151a2e4
> 
> Arf, right.
> 
> 
>> Maybe we should add some doc to the contributors guide for it. It seems
>> to be run by one of the robots anyway.
> 
> It is enabled by default.
> 

Well, enabled by default if someone has the dictionary and set the
variable, so not really /that/ default.
Sent doc patch https://patchwork.dpdk.org/patch/63162/

> It does catch "informations".
> 
> But it does not pick, for example, my typo on "preferrence" (no
> excuse, in French, it takes only one r too).
> 
> Did you use https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary.txt
> ?

Yes, I used the latest upstream dictionary at the time.

> Not sure the robots are using the latest version.
> 
> 
> --
> David Marchand
>
diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index cbe8d10fc..935e8fefe 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -284,5 +284,5 @@  read_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
 
 	if (msglen != buflen || (msgh.msg_flags & (MSG_TRUNC | MSG_CTRUNC))) {
-		RTE_LOG(ERR, EAL, "truncted msg\n");
+		RTE_LOG(ERR, EAL, "truncated msg\n");
 		return -1;
 	}
@@ -1072,5 +1072,5 @@  rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
 
 	if (gettimeofday(&now, NULL) < 0) {
-		RTE_LOG(ERR, EAL, "Faile to get current time\n");
+		RTE_LOG(ERR, EAL, "Failed to get current time\n");
 		rte_errno = errno;
 		return -1;
diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
index 28e10cdc4..95f615c2e 100644
--- a/lib/librte_eal/linux/eal/eal_vfio.c
+++ b/lib/librte_eal/linux/eal/eal_vfio.c
@@ -1295,5 +1295,5 @@  vfio_type1_dma_mem_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova,
 			if (errno == EEXIST) {
 				RTE_LOG(DEBUG, EAL,
-					" Memory segment is allready mapped,"
+					" Memory segment is already mapped,"
 					" skipping");
 			} else {
@@ -1380,5 +1380,5 @@  vfio_spapr_dma_do_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova,
 			if (errno == EBUSY) {
 				RTE_LOG(DEBUG, EAL,
-					" Memory segment is allready mapped,"
+					" Memory segment is already mapped,"
 					" skipping");
 			} else {
diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
index 7c386f891..22989244a 100644
--- a/lib/librte_power/power_acpi_cpufreq.c
+++ b/lib/librte_power/power_acpi_cpufreq.c
@@ -31,5 +31,5 @@ 
 #define FOPEN_OR_ERR_RET(f, retval) do { \
 		if ((f) == NULL) { \
-			RTE_LOG(ERR, POWER, "File not openned\n"); \
+			RTE_LOG(ERR, POWER, "File not opened\n"); \
 			return retval; \
 		} \
@@ -110,5 +110,5 @@  set_freq_internal(struct rte_power_info *pi, uint32_t idx)
 		return 0;
 
-	POWER_DEBUG_TRACE("Freqency[%u] %u to be set for lcore %u\n",
+	POWER_DEBUG_TRACE("Frequency[%u] %u to be set for lcore %u\n",
 			idx, pi->freqs[idx], pi->lcore_id);
 	if (fseek(pi->f, 0, SEEK_SET) < 0) {
diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c
index ecbcb3ac9..8f095e0ab 100644
--- a/lib/librte_power/power_pstate_cpufreq.c
+++ b/lib/librte_power/power_pstate_cpufreq.c
@@ -34,5 +34,5 @@ 
 #define FOPEN_OR_ERR_RET(f, retval) do { \
 		if ((f) == NULL) { \
-			RTE_LOG(ERR, POWER, "File not openned\n"); \
+			RTE_LOG(ERR, POWER, "File not opened\n"); \
 			return retval; \
 		} \
@@ -288,5 +288,5 @@  set_freq_internal(struct pstate_power_info *pi, uint32_t idx)
 		}
 
-		POWER_DEBUG_TRACE("Freqency '%u' to be set for lcore %u\n",
+		POWER_DEBUG_TRACE("Frequency '%u' to be set for lcore %u\n",
 				  target_freq, pi->lcore_id);
 
@@ -311,5 +311,5 @@  set_freq_internal(struct pstate_power_info *pi, uint32_t idx)
 		}
 
-		POWER_DEBUG_TRACE("Freqency '%u' to be set for lcore %u\n",
+		POWER_DEBUG_TRACE("Frequency '%u' to be set for lcore %u\n",
 				  target_freq, pi->lcore_id);
 
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index a34bc7f9a..ebb2ff6c2 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -133,5 +133,5 @@  read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
 
 	if (msgh.msg_flags & (MSG_TRUNC | MSG_CTRUNC)) {
-		RTE_LOG(ERR, VHOST_CONFIG, "truncted msg\n");
+		RTE_LOG(ERR, VHOST_CONFIG, "truncated msg\n");
 		return -1;
 	}