From patchwork Sat Jan 4 01:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 64209 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 196A4A04DD; Sat, 4 Jan 2020 02:35:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBA1A1D56E; Sat, 4 Jan 2020 02:34:14 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id D974A1D54F for ; Sat, 4 Jan 2020 02:34:06 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id y8so19609206pll.13 for ; Fri, 03 Jan 2020 17:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LlyC1Z1TT0HIqDsd8sET7tu3nOmVbmNuMi3nCCphs1o=; b=DRfDNndF3slKSoQ0AmxrCgoQSh9hctvsdzzMpneE6qh7Ggi2jpJETBYDwo7DbCqioC XXbykqVmHvNM/USbJSNVtmvc4MS3rqfEDT0kZvABCef+H/bBE2gKE05P/53bYBdwNY6d 2ozzU5OlCFNZOJWHh+f9M8BSQw9OvWxwtrS6Mr8cLroKpkaGClMj9vhQrLGnjOPT3so0 uMHeRhwv/qU7BZFfAwzW5rmHfi10tkpDgQ5QC43KCx6JJ+szfeuL+3JccLWTWUPHCQKt m0PDKezvs+dzFiG9v/62Hh/FyTYK6B/qlsJYyOx/XynaGnsnVSpZGEh/iztvy99JcajZ 5p4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LlyC1Z1TT0HIqDsd8sET7tu3nOmVbmNuMi3nCCphs1o=; b=ugCN0lt7KrcWGsC7j4/hi9BBLOwe2lnusaicOBzvADGqTA32Tp2GNuZ9+FS8lDF78/ m8OvM8dfOwmonvCFvzCh3yp5X6j76RPqDacOofCtrY8zsPxk8wu0iZlC5lqG3+DJN5mI nOgkUm6we8TbSqbWLoT0EyUI06bG33SjrZ2jDZKgWQQTdspK92J8S/3/p+CnVOTWQcs3 4jPvAHD90WHzjPAFVd4lUHluLdlg3bNq3PCJUf0hw7ijDe8h7YQ+xo+/uS6m3EM7q/VE 5kwSY6GIWPcRnsk9LinpGZJZDlw8MEtkPgLCjqvTXcDpYt3ghHW4Mi391os4raZMUnmP Iv8Q== X-Gm-Message-State: APjAAAVci8txcOco8V9Rs08Xf9bjm4eOvKfc7pH89VN3YyJMBQGvnQN5 wNDmpqst2PK27dyfw1ESqSXN9l7k6To= X-Google-Smtp-Source: APXvYqxUVxdtubENO7bt9fiNEXeM8zJsjckU7HqUjzWkkaNOIwT4lZ4PXHqvCTnxcPdusQObKdAW9A== X-Received: by 2002:a17:902:6ac2:: with SMTP id i2mr93799290plt.221.1578101645565; Fri, 03 Jan 2020 17:34:05 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 17:34:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 3 Jan 2020 17:33:39 -0800 Message-Id: <20200104013341.19809-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200104013341.19809-1-stephen@networkplumber.org> References: <20200104013341.19809-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 12/14] ethdev: raise priority of old driver warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The priority of the message about drivers not using new (correct) behaviour on close was debug. And debug messages are typically surpressed and never seen. Raise the priority so that broken drivers are visible and hopefully get developers to fix. Signed-off-by: Stephen Hemminger Acked-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 6e9cb243ea80..545687dbc5c9 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1717,7 +1717,7 @@ rte_eth_dev_close(uint16_t port_id) rte_eth_dev_release_port(dev); return; } - RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n" + RTE_ETHDEV_LOG(NOTICE, "Port closing is using an old behaviour.\n" "The driver %s should migrate to the new behaviour.\n", dev->device->driver->name); /* old behaviour: only free queue arrays */