diff mbox series

[v1] net/ice: resolve unchecked return value

Message ID 20200212053710.16424-1-sunil.pai.g@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers show
Series [v1] net/ice: resolve unchecked return value | expand

Checks

Context Check Description
ci/Intel-compilation fail apply issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Sunil Pai G Feb. 12, 2020, 5:37 a.m. UTC
This checks the return value of the function ice_xmit_cleanup

Coverity issue: 353623
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: wenzhuo.lu@intel.com

Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiaolong Ye Feb. 14, 2020, 9:46 a.m. UTC | #1
On 02/12, Sunil Pai G wrote:
>This checks the return value of the function ice_xmit_cleanup
>
>Coverity issue: 353623
>Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>Cc: wenzhuo.lu@intel.com

Cc: stable@dpdk.org

>
>Signed-off-by: Sunil Pai G <sunil.pai.g@intel.com>
>---
> drivers/net/ice/ice_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
>index ce5b8e6ca..60c411bfa 100644
>--- a/drivers/net/ice/ice_rxtx.c
>+++ b/drivers/net/ice/ice_rxtx.c
>@@ -2471,7 +2471,7 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
> 
> 	/* Check if the descriptor ring needs to be cleaned. */
> 	if (txq->nb_tx_free < txq->tx_free_thresh)
>-		ice_xmit_cleanup(txq);
>+		(void)ice_xmit_cleanup(txq);
> 
> 	for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
> 		tx_pkt = *tx_pkts++;
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ce5b8e6ca..60c411bfa 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2471,7 +2471,7 @@  ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 
 	/* Check if the descriptor ring needs to be cleaned. */
 	if (txq->nb_tx_free < txq->tx_free_thresh)
-		ice_xmit_cleanup(txq);
+		(void)ice_xmit_cleanup(txq);
 
 	for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
 		tx_pkt = *tx_pkts++;