diff mbox series

[01/28] net/ice/base: fix uninitialized stack variables

Message ID	20200309114357.31800-2-qi.z.zhang@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	xiaolong ye
Headers	From: Qi Zhang <qi.z.zhang@intel.com> To: qiming.yang@intel.com, beilei.xing@intel.com Cc: xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org, Jesse Brandeburg <jesse.brandeburg@intel.com>, Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> Date: Mon, 9 Mar 2020 19:43:30 +0800 Message-Id: <20200309114357.31800-2-qi.z.zhang@intel.com> In-Reply-To: <20200309114357.31800-1-qi.z.zhang@intel.com> References: <20200309114357.31800-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH 01/28] net/ice/base: fix uninitialized stack variables Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update ice base code \| [00/28] update ice base code [01/28] net/ice/base: fix uninitialized stack variables [02/28] net/ice/base: add and update E822 device IDs [03/28] net/ice/base: fix removing MAC rule [04/28] net/ice/base: read PSM clock frequency from register [05/28] net/ice/base: allow VLAN and ethertype filter for port [06/28] net/ice/base: replace u16 with enum [07/28] net/ice/base: use struct size helper [08/28] net/ice/base: use descriptive vairiable name than type [09/28] net/ice/base: refactor a function [10/28] net/ice/base: add NVM netlist macros [11/28] net/ice/base: minor fixes [12/28] net/ice/base: support GTPU uplink and downlink [13/28] net/ice/base: add link default override support [14/28] net/ice/base: add dedicate MAC type for E810 [15/28] net/ice/base: capitalize abbreviations [16/28] net/ice/base: add PHY number definition values [17/28] net/ice/base: add shared driver parameter command [18/28] net/ice/bse: add AN masks to Get PHY Caps [19/28] net/ice/base: xtract logic of flat NVM read to function [20/28] net/ice/base: add macro specifying max NVM offset [21/28] net/ice/base: implement new sr read functions [22/28] net/ice/base: couple casting issue fixes [23/28] net/ice/base: support PHY persistent feature [24/28] net/ice/base: store NVM version info in extracted format [25/28] net/ice/base: add ACL module [26/28] net/ice/base: update copyright date [27/28] net/ice/base: add the hook to send AdminQ command [28/28] net/ice/base: don't access some hardware registers in DCF

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/iol-testing	success	Testing PASS
ci/iol-mellanox-Performance	success	Performance Testing PASS
ci/Intel-compilation	success	Compilation OK

Commit Message

Qi Zhang March 9, 2020, 11:43 a.m. UTC

  Via code inspection, I found that some partially initialized
stack variables were being passed along to called functions,
which could eventually result in those uninitialized members
being used.  To fix this, make sure the local variables are
zeroed out before partially initializing them.  This should
prevent any unintended consequences from using stack memory that
might have junk in it.

In addition to the memsets, this patch also initializes one
member in one function, that needed to be initialized to non-zero.

Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe")
Cc: stable@dpdk.org

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_switch.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
index 085f34406..e88d0f7fe 100644
--- a/drivers/net/ice/base/ice_switch.c
+++ b/drivers/net/ice/base/ice_switch.c
@@ -6227,9 +6227,12 @@  ice_adv_add_update_vsi_list(struct ice_hw *hw,
 		if (status)
 			return status;
 
+		ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);
 		tmp_fltr.fltr_rule_id = cur_fltr->fltr_rule_id;
 		tmp_fltr.fltr_act = ICE_FWD_TO_VSI_LIST;
 		tmp_fltr.fwd_id.vsi_list_id = vsi_list_id;
+		tmp_fltr.lkup_type = ICE_SW_LKUP_LAST;
+
 		/* Update the previous switch rule of "forward to VSI" to
 		 * "fwd to VSI list"
 		 */
@@ -6473,6 +6476,7 @@  ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
 	if (rinfo->sw_act.fltr_act == ICE_FWD_TO_VSI) {
 		struct ice_fltr_info tmp_fltr;
 
+		ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);
 		tmp_fltr.fltr_rule_id =
 			LE16_TO_CPU(s_rule->pdata.lkup_tx_rx.index);
 		tmp_fltr.fltr_act = ICE_FWD_TO_VSI;
@@ -6557,6 +6561,8 @@  ice_adv_rem_update_vsi_list(struct ice_hw *hw, u16 vsi_handle,
 						  lkup_type);
 		if (status)
 			return status;
+
+		ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);
 		tmp_fltr.fltr_rule_id = fm_list->rule_info.fltr_rule_id;
 		fm_list->rule_info.sw_act.fltr_act = ICE_FWD_TO_VSI;
 		tmp_fltr.fltr_act = ICE_FWD_TO_VSI;