From patchwork Tue Apr 7 16:27:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 67902 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BBF8A0577; Tue, 7 Apr 2020 18:28:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C66D1BEE3; Tue, 7 Apr 2020 18:28:59 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3F5C71BEE1 for ; Tue, 7 Apr 2020 18:28:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586276937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2aDZxkVkv++HoAeGrpHBDtwe+kmF1rLZ01tuUlcVKvQ=; b=QiWajMVWJkzXSGTVGkO4rGnpNJWjcXINUD8DDzi2J7JdC7ZTwea51P1i2xlr72faOCheWW 7V1rZ01wbryt6Id4nGLAt68Xy0OW3o493iZdZIk91CdgM9NjhisqVquzPOxjhxetA6TP/J Thsa1sfKRgJtkgmoqi9IWHsJR05p9VI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-Hs9ikiynP1W-CziZAk3Cag-1; Tue, 07 Apr 2020 12:28:14 -0400 X-MC-Unique: Hs9ikiynP1W-CziZAk3Cag-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C52F91088395; Tue, 7 Apr 2020 16:28:11 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4977C5DA7C; Tue, 7 Apr 2020 16:28:07 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com Cc: ravi1.kumar@amd.com, g.singh@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, johndale@cisco.com, hyonkim@cisco.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rmody@marvell.com, shshaikh@marvell.com, matan@mellanox.com, shahafs@mellanox.com, declan.doherty@intel.com, cristian.dumitrescu@intel.com, Kevin Traynor Date: Tue, 7 Apr 2020 17:27:55 +0100 Message-Id: <20200407162755.6802-1-ktraynor@redhat.com> In-Reply-To: <20200325141137.7088-1-ktraynor@redhat.com> References: <20200325141137.7088-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" stringop-overflow warns when it sees a possible overflow in a string operation. In the rte_memcpy functions different implementations are used depending on the size. stringop-overflow is raised for the paths in the function where it sees the static size of the src could be overflowed. However, in reality a correct size argument and in some cases dynamic allocation would ensure that this does not happen. Disable this warning at the top level as it is being raised on several components. For example, in the case below for key, the correct path will be chosen in rte_memcpy_generic at runtime based on the size argument but as some paths in the function could lead to a cast to 32 bytes a warning is raised. In function ‘_mm256_storeu_si256’, inlined from ‘rte_memcpy_generic’ at ../lib/librte_eal/common/include/arch/x86/rte_memcpy.h:315:2, inlined from ‘iavf_configure_rss_key’ at ../lib/librte_eal/common/include/arch/x86/rte_memcpy.h:869:10: /usr/lib/gcc/x86_64-redhat-linux/10/include/avxintrin.h:928:8: warning: writing 32 bytes into a region of size 1 [-Wstringop-overflow=] 928 | *__P = __A; | ~~~~~^~~~~ In file included from ../drivers/net/iavf/../../common/iavf/iavf_prototype.h:10, from ../drivers/net/iavf/iavf.h:9, from ../drivers/net/iavf/iavf_vchnl.c:22: ../drivers/net/iavf/iavf_vchnl.c: In function ‘iavf_configure_rss_key’: ../drivers/net/iavf/../../common/iavf/virtchnl.h:508:5: note: at offset 0 to object ‘key’ with size 1 declared here 508 | u8 key[1]; /* RSS hash key, packed bytes */ | ^~~ Bugzilla ID: 394 Bugzilla ID: 421 Signed-off-by: Kevin Traynor --- config/meson.build | 3 ++- mk/toolchain/gcc/rte.vars.mk | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 58421342b..476a667a9 100644 --- a/config/meson.build +++ b/config/meson.build @@ -200,5 +200,6 @@ warning_flags = [ '-Wno-address-of-packed-member', '-Wno-packed-not-aligned', - '-Wno-missing-field-initializers' + '-Wno-missing-field-initializers', + '-Wno-stringop-overflow' ] if not dpdk_conf.get('RTE_ARCH_64') diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index f19305e49..fe4b8c705 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -101,4 +101,7 @@ endif WERROR_FLAGS += -Wno-address-of-packed-member +# disable stringop-overflow warnings +WERROR_FLAGS += -Wno-stringop-overflow + export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS