From patchwork Wed May 6 21:31:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dybkowski, AdamX" X-Patchwork-Id: 69884 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03495A034E; Wed, 6 May 2020 23:31:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C89991DAD8; Wed, 6 May 2020 23:31:12 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D849A1DABF for ; Wed, 6 May 2020 23:31:10 +0200 (CEST) IronPort-SDR: 7KU+T9JQu+ZBeTSFxJ5Z5HlD6Da0ZNTjA2vJtfDQmB5EldVFxDqzD+taRPOo/jaO5zx0l2DmJL IK6ejhdRJaaQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 14:31:10 -0700 IronPort-SDR: yzOuQs2lqlyQztHjVnVpgMf14VgNNWvrg9sIP+KRyH2nG4kUvGQBPZJea8NJpi5lFfzm+7tD2I vrL7UKTf3OPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="369920003" Received: from pbronowx-mobl.ger.corp.intel.com (HELO addy-VirtualBox.ger.corp.intel.com) ([10.104.121.88]) by fmsmga001.fm.intel.com with ESMTP; 06 May 2020 14:31:08 -0700 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com Cc: Adam Dybkowski Date: Wed, 6 May 2020 23:31:07 +0200 Message-Id: <20200506213107.26569-1-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] common/qat: fix coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes Coverity issue #357770 by removing the non-essential check for NULL pointer. Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation") Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index 64dfd85c4..60ef8bf0f 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -864,7 +864,7 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops) resp_msg = (uint8_t *)rx_queue->base_addr + head; - if (ops != NULL && nb_fw_responses) { + if (nb_fw_responses) { /* only move on to next op if one was ready to return * to API */