diff mbox series

[v2] net/igc: remove some useless log

Message ID 20200507093636.19008-1-alvinx.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers show
Series [v2] net/igc: remove some useless log | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/Intel-compilation fail Compilation issues
ci/travis-robot warning Travis build: failed
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Alvin Zhang May 7, 2020, 9:36 a.m. UTC
From: Alvin Zhang <alvinx.zhang@intel.com>

Some log will always be printed when the device is initialized
and shut down, which will mislead users and should be removed.

Fixes: 746664d546fb (net/igc: implement flow API)
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---

V2: update git log

 drivers/net/igc/igc_txrx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Xiaolong Ye May 11, 2020, 2:57 a.m. UTC | #1
On 05/07, alvinx.zhang@intel.com wrote:
>From: Alvin Zhang <alvinx.zhang@intel.com>
>
>Some log will always be printed when the device is initialized
>and shut down, which will mislead users and should be removed.
>
>Fixes: 746664d546fb (net/igc: implement flow API)
>Cc: stable@dpdk.org
>
>Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>---
>
>V2: update git log
>
> drivers/net/igc/igc_txrx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
>index 5b269b6..4654ec4 100644
>--- a/drivers/net/igc/igc_txrx.c
>+++ b/drivers/net/igc/igc_txrx.c
>@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
> {
> 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
> 
>-	if (!rss_filter->enable) {
>-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
>+	if (!rss_filter->enable)
> 		return;
>-	}
> 
> 	/* recover default RSS configuration */
> 	igc_rss_configure(dev);
>-- 
>1.8.3.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index 5b269b6..4654ec4 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1035,10 +1035,8 @@  int eth_igc_rx_descriptor_status(void *rx_queue, uint16_t offset)
 {
 	struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
 
-	if (!rss_filter->enable) {
-		PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
+	if (!rss_filter->enable)
 		return;
-	}
 
 	/* recover default RSS configuration */
 	igc_rss_configure(dev);