[v5,3/8] pci: build on Windows
Checks
Commit Message
From: Tal Shnaiderman <talshn@mellanox.com>
Added <sys/types.h> in Windows header file includes
to include off_t type since it is needed by PCI.
export per_lcore__rte_errno from eal since it is needed by PCI.
Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/rte_eal_version.map | 3 +++
lib/librte_eal/windows/include/rte_os.h | 1 +
lib/meson.build | 5 ++++-
4 files changed, 9 insertions(+), 1 deletion(-)
Comments
09/06/2020 12:31, talshn@mellanox.com:
> From: Tal Shnaiderman <talshn@mellanox.com>
>
> Added <sys/types.h> in Windows header file includes
> to include off_t type since it is needed by PCI.
Why is it added in rte_os.h and not in the file using off_t?
> export per_lcore__rte_errno from eal since it is needed by PCI.
[...]
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -386,6 +386,9 @@ EXPERIMENTAL {
> + # added in 20.08
> + __emutls_v.per_lcore__rte_errno;
I think it is not needed.
@@ -1,5 +1,6 @@
EXPORTS
__rte_panic
+ per_lcore__rte_errno
rte_calloc
rte_calloc_socket
rte_eal_get_configuration
@@ -386,6 +386,9 @@ EXPERIMENTAL {
rte_trace_point_lookup;
rte_trace_regexp;
rte_trace_save;
+
+ # added in 20.08
+ __emutls_v.per_lcore__rte_errno;
};
INTERNAL {
@@ -15,6 +15,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <sys/types.h>
#ifdef __cplusplus
extern "C" {
@@ -36,7 +36,10 @@ libraries = [
'flow_classify', 'bpf', 'graph', 'node']
if is_windows
- libraries = ['kvargs','eal'] # only supported libraries for windows
+ libraries = [
+ 'kvargs','eal',
+ 'pci',
+ ] # only supported libraries for windows
endif
default_cflags = machine_args