| Message ID | 20200624084510.35277-1-joyce.kong@arm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | [v1] net/virtio: simplify variable name | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-testing | success | Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/travis-robot | success | Travis build: passed |
| ci/iol-nxp-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/checkpatch | success | coding style OK |
<snip> > Subject: [PATCH v1] net/virtio: simplify variable name > > Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of > vq->hw in later code. > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > --- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c > b/drivers/net/virtio/virtio_rxtx_simple_neon.c > index 363e2b330..8e6fa1fd7 100644 > --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c > +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c > @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf > **rx_pkts, > */ > uint16x8_t len_adjust = { > 0, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, > + (uint16_t)hw->vtnet_hdr_size, 0, > + (uint16_t)hw->vtnet_hdr_size, > 0, > 0, 0 > }; > -- > 2.27.0
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Joyce Kong > Sent: Wednesday, June 24, 2020 4:45 PM > To: jerinj@marvell.com; maxime.coquelin@redhat.com; Wang, Zhihong > <zhihong.wang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; > ruifeng.wang@arm.com; honnappa.nagarahalli@arm.com; phil.yang@arm.com > Cc: dev@dpdk.org; nd@arm.com > Subject: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name > > Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of vq- > >hw in later code. > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > --- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c > b/drivers/net/virtio/virtio_rxtx_simple_neon.c > index 363e2b330..8e6fa1fd7 100644 > --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c > +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c > @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf > **rx_pkts, > */ > uint16x8_t len_adjust = { > 0, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, > + (uint16_t)hw->vtnet_hdr_size, 0, > + (uint16_t)hw->vtnet_hdr_size, > 0, > 0, 0 > }; > -- > 2.27.0 Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
On 6/24/20 10:45 AM, Joyce Kong wrote: > Virtio_hw *hw has been pointed to vq->hw, it is better to use > hw instead of vq->hw in later code. > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > --- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c > index 363e2b330..8e6fa1fd7 100644 > --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c > +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c > @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, > */ > uint16x8_t len_adjust = { > 0, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, 0, > - (uint16_t)vq->hw->vtnet_hdr_size, > + (uint16_t)hw->vtnet_hdr_size, 0, > + (uint16_t)hw->vtnet_hdr_size, > 0, > 0, 0 > }; > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime
On 6/30/20 9:27 AM, Maxime Coquelin wrote: > > > On 6/24/20 10:45 AM, Joyce Kong wrote: >> Virtio_hw *hw has been pointed to vq->hw, it is better to use >> hw instead of vq->hw in later code. >> >> Signed-off-by: Joyce Kong <joyce.kong@arm.com> >> --- >> drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c >> index 363e2b330..8e6fa1fd7 100644 >> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c >> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c >> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, >> */ >> uint16x8_t len_adjust = { >> 0, 0, >> - (uint16_t)vq->hw->vtnet_hdr_size, 0, >> - (uint16_t)vq->hw->vtnet_hdr_size, >> + (uint16_t)hw->vtnet_hdr_size, 0, >> + (uint16_t)hw->vtnet_hdr_size, >> 0, >> 0, 0 >> }; >> > > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Thanks, > Maxime > Applied to dpdk-next-virtio/master Thanks, Maxime
diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c index 363e2b330..8e6fa1fd7 100644 --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, */ uint16x8_t len_adjust = { 0, 0, - (uint16_t)vq->hw->vtnet_hdr_size, 0, - (uint16_t)vq->hw->vtnet_hdr_size, + (uint16_t)hw->vtnet_hdr_size, 0, + (uint16_t)hw->vtnet_hdr_size, 0, 0, 0 };
Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of vq->hw in later code. Signed-off-by: Joyce Kong <joyce.kong@arm.com> --- drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)