[v3,1/2] app/test-eventdev: Fix pipeline atq
Checks
Commit Message
if-check is required to check the capability of all type queue.
Fixes: 6bf570a9911 ("app/eventdev: add pipeline atq test")
Cc: stable@dpdk.org
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
v3:
* Added patch
1. event/dpaa2: Add all type queue capability flag
v2:
* Removed unrequired patches
1. app/test-eventdev: Enhancing perf-queue packet flow
2. app/test-eventdev: Removed unwanted checks
3. event/dpaa2: Add all type queue capability flag
4. app/test-eventdev: Enhancing perf-atq packet flow
5. app/test-eventdev: fix eventdev queues
---
app/test-eventdev/test_pipeline_atq.c | 2 ++
1 file changed, 2 insertions(+)
Comments
>Subject: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq
./devtools/check-git-log.sh
Wrong headline uppercase:
app/test-eventdev: Fix pipeline atq
Having a more informative commit title and message would be helpful,
Something like:
" app/eventdev: fix capability check in pipeline atq test"
>
>if-check is required to check the capability of all type queue.
"Add all type queue capability check before configuring event device
for pipeline atq test."
>
>Fixes: 6bf570a9911 ("app/eventdev: add pipeline atq test")
>Cc: stable@dpdk.org
>
>Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
With above changes
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
>v3:
>* Added patch
>1. event/dpaa2: Add all type queue capability flag
>
>v2:
>* Removed unrequired patches
>1. app/test-eventdev: Enhancing perf-queue packet flow
>2. app/test-eventdev: Removed unwanted checks
>3. event/dpaa2: Add all type queue capability flag
>4. app/test-eventdev: Enhancing perf-atq packet flow
>5. app/test-eventdev: fix eventdev queues
>---
> app/test-eventdev/test_pipeline_atq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-
>eventdev/test_pipeline_atq.c
>index 8e8686c145..0872b25b53 100644
>--- a/app/test-eventdev/test_pipeline_atq.c
>+++ b/app/test-eventdev/test_pipeline_atq.c
>@@ -495,6 +495,8 @@ pipeline_atq_capability_check(struct
>evt_options *opt)
> evt_nr_active_lcores(opt->wlcores),
> dev_info.max_event_ports);
> }
>+ if (!evt_has_all_types_queue(opt->dev_id))
>+ return false;
>
> return true;
> }
>--
>2.17.1
22/07/2020 03:13, Pavan Nikhilesh Bhagavatula:
>
> >Subject: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq
>
> ./devtools/check-git-log.sh
> Wrong headline uppercase:
> app/test-eventdev: Fix pipeline atq
>
> Having a more informative commit title and message would be helpful,
> Something like:
>
> " app/eventdev: fix capability check in pipeline atq test"
What means "atq"?
If it is an acronym, it should be uppercased.
@@ -495,6 +495,8 @@ pipeline_atq_capability_check(struct evt_options *opt)
evt_nr_active_lcores(opt->wlcores),
dev_info.max_event_ports);
}
+ if (!evt_has_all_types_queue(opt->dev_id))
+ return false;
return true;
}