diff mbox series

[v2,20.08,6/6] check_maintainers: change variable names

Message ID 20200730005804.19251-7-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series inclusive language fixes and deprecation notices |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger July 30, 2020, 12:58 a.m. UTC 
  Change variable names in python script: replace whitelist
with include_files and blacklist with exclude_files.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Luca Boccassi <bluca@debian.org>
---
 devtools/check-maintainers.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Monjalon Aug. 6, 2020, 4:55 p.m. UTC | #1 
30/07/2020 02:58, Stephen Hemminger:
> Change variable names in python script: replace whitelist

It is not a python script.

> with include_files and blacklist with exclude_files.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Luca Boccassi <bluca@debian.org>
> ---
> -			whitelist=$(files $flines)
> -			blacklist=$(files $xlines)
> -			match=$(aminusb "$whitelist" "$blacklist")
> -			if [ -n "$whitelist" ] ; then
> +			include_files=$(files $flines)
> +			exclude_files=$(files $xlines)
> +			match=$(aminusb "$include_files" "$exclude_files")
> +			if [ -n "$include_files" ] ; then

With above nit fixed,
Acked-by: Thomas Monjalon <thomas@monjalon.net>
diff mbox series

Patch

diff --git a/devtools/check-maintainers.sh b/devtools/check-maintainers.sh
index 85a300f0a029..df3f740b6e84 100755
--- a/devtools/check-maintainers.sh
+++ b/devtools/check-maintainers.sh
@@ -42,10 +42,10 @@  parse_fx () # <index file>
 	for line in $( (sed '/^-\+$/d' $1 ; echo) | sed 's,^$,§,') ; do
 		if echo "$line" | grep -q '^§$' ; then
 			# empty line delimit end of section
-			whitelist=$(files $flines)
-			blacklist=$(files $xlines)
-			match=$(aminusb "$whitelist" "$blacklist")
-			if [ -n "$whitelist" ] ; then
+			include_files=$(files $flines)
+			exclude_files=$(files $xlines)
+			match=$(aminusb "$include_files" "$exclude_files")
+			if [ -n "$include_files" ] ; then
 				printf "# $title "
 				maintainers=$(echo "$maintainers" | sed -r 's,.*<(.*)>.*,\1,')
 				maintainers=$(printf "$maintainers" | sed -e 's,^,<,' -e 's,$,>,')