| Message ID | 20201008153048.19369-5-rohit.raj@nxp.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | [v4,1/5] eal: add API for bus close | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/travis-robot | success | Travis build: passed |
| ci/checkpatch | success | coding style OK |
> Subject: [dpdk-dev] [PATCH v4 5/5] eal/windows: added support for > rte_bus_close API > > External email: Use caution opening links or attachments > > > From: Rohit Raj <rohit.raj@nxp.com> > > Added support for rte_bus_close API on windows to reset the devices on > the bus to default state. > > Signed-off-by: Rohit Raj <rohit.raj@nxp.com> > --- > lib/librte_eal/windows/eal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index > bc48f27ab..9eb32077b 100644 > --- a/lib/librte_eal/windows/eal.c > +++ b/lib/librte_eal/windows/eal.c > @@ -251,7 +251,7 @@ rte_eal_cleanup(void) { > struct internal_config *internal_conf = > eal_get_internal_configuration(); > - > + rte_bus_close(); > eal_cleanup_config(internal_conf); > return 0; > } > -- > 2.17.1 Hi Rohit, You need to add rte_bus_close to lib/librte_eal/rte_eal_exports.def as it is currently the way to export functions from eal in Windows clang build. Thanks, Tal.
On Thu, Oct 08, 2020 at 09:00:47PM +0530, rohit.raj@nxp.com wrote: > From: Rohit Raj <rohit.raj@nxp.com> > > Added support for rte_bus_close API on windows to reset the devices on > the bus to default state. > > Signed-off-by: Rohit Raj <rohit.raj@nxp.com> > --- > lib/librte_eal/windows/eal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c > index bc48f27ab..9eb32077b 100644 > --- a/lib/librte_eal/windows/eal.c > +++ b/lib/librte_eal/windows/eal.c > @@ -251,7 +251,7 @@ rte_eal_cleanup(void) > { > struct internal_config *internal_conf = > eal_get_internal_configuration(); > - > + rte_bus_close(); Should we verify the return code here? > eal_cleanup_config(internal_conf); > return 0; > }
diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index bc48f27ab..9eb32077b 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -251,7 +251,7 @@ rte_eal_cleanup(void) { struct internal_config *internal_conf = eal_get_internal_configuration(); - + rte_bus_close(); eal_cleanup_config(internal_conf); return 0; }