[1/3] common/iavf: replace macro for MAC address length
Checks
Commit Message
Replace ETH_ALEN with VIRTCHNL_ETH_LENGTH_OF_ADDRESS.
Signed-off-by: Maciej Rabeda <maciej.rabeda@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/common/iavf/virtchnl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 10/15/2020 1:43 AM, Qi Zhang wrote:
> Replace ETH_ALEN with VIRTCHNL_ETH_LENGTH_OF_ADDRESS.
>
Why? They have same value, righ? Can you please put the reason, and impact if
any to the commit log.
>
> Signed-off-by: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/common/iavf/virtchnl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index 81eabd73be..a5a300afe3 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -624,8 +624,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_tc_info);
> */
>
> struct virtchnl_l4_spec {
> - u8 src_mac[ETH_ALEN];
> - u8 dst_mac[ETH_ALEN];
> + u8 src_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
> + u8 dst_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
> /* vlan_prio is part of this 16 bit field even from OS perspective
> * vlan_id:12 is actual vlan_id, then vlanid:bit14..12 is vlan_prio
> * in future, when decided to offload vlan_prio, pass that information
>
@@ -624,8 +624,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_tc_info);
*/
struct virtchnl_l4_spec {
- u8 src_mac[ETH_ALEN];
- u8 dst_mac[ETH_ALEN];
+ u8 src_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
+ u8 dst_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
/* vlan_prio is part of this 16 bit field even from OS perspective
* vlan_id:12 is actual vlan_id, then vlanid:bit14..12 is vlan_prio
* in future, when decided to offload vlan_prio, pass that information