[v2,1/2] build: fix gcc compile warnings by adding wformat

Message ID 20201118181103.3865787-2-conor.walsh@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ajit Khaparde
Series build: add Wformat to fix gcc compile warnings and format fixes |


Context Check Description
ci/checkpatch success coding style OK

Commit Message

Conor Walsh Nov. 18, 2020, 6:11 p.m. UTC
  On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a
warning on every build step saying that -Wformat-nonliteral and
-Wformat-security warnings will be ignored unless -Wformat is
also specified as a compiler flag. When the build is run with -werror
the build will fail due to these warnings.

Exact warning returned:
cc1: error: -Wformat-nonliteral ignored without -Wformat
cc1: error: -Wformat-security ignored without -Wformat
cc1: all warnings being treated as errors

This patch adds the -Wformat flag to config/meson.build. The warning id
181 has also been suppressed in icc as icc was showing false positives
with -Wformat enabled.

Fixes: 524a0d5d66b9 ("build: enable extra warnings with meson")
Cc: bruce.richardson@intel.com

Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Tested-by: Chen, LingliX <linglix.chen@intel.com>
 config/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/config/meson.build b/config/meson.build
index a29693b883..c02802c18e 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -194,6 +194,7 @@  warning_flags = [
 	# additional warnings in alphabetical order
+	'-Wformat',
@@ -220,7 +221,7 @@  if not dpdk_conf.get('RTE_ARCH_64')
 	warning_flags += '-Wno-pointer-to-int-cast'
 if cc.get_id() == 'intel'
-	warning_ids = [188, 2203, 2279, 2557, 3179, 3656]
+	warning_ids = [181, 188, 2203, 2279, 2557, 3179, 3656]
 	foreach i:warning_ids
 		warning_flags += '-diag-disable=@0@'.format(i)