From patchwork Tue Apr 20 13:21:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 91879 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B04AEA0548; Tue, 20 Apr 2021 15:22:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 352AF41749; Tue, 20 Apr 2021 15:22:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 228B341735 for ; Tue, 20 Apr 2021 15:22:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618924921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FcYUZsmeB+SqUW/HgBEAWC9kfviIQ/4j7/BApHhbmf4=; b=Se7zUqEfwPm6uVpR0ny4Kz+BbJBJih2/As5GHYYno0L8quXDFM7uqxjs123IW60hVDICbu /+8rpVTA3Zdc8Bo92A1HMYhweB0n7EyNGHBg40NNDVrYNagcVXf8aI8oucCJBLlqR17yuu VVUUTLY5fS4YjhqZTQCvFEpa/6I2VVQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-14A7zD57NNujgcjFWfG5KQ-1; Tue, 20 Apr 2021 09:21:59 -0400 X-MC-Unique: 14A7zD57NNujgcjFWfG5KQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6450B18BA2A7; Tue, 20 Apr 2021 13:21:58 +0000 (UTC) Received: from rh.Home (ovpn-112-162.ams2.redhat.com [10.36.112.162]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E72E500DC; Tue, 20 Apr 2021 13:21:57 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: Kevin Traynor , Olivier Matz Date: Tue, 20 Apr 2021 14:21:49 +0100 Message-Id: <20210420132150.167817-1-ktraynor@redhat.com> In-Reply-To: <20210420130915.166692-1-ktraynor@redhat.com> References: <20210420130915.166692-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v2 1/2] app/test: fix clang 12 warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" clang 12 gives a warning about string concatenation in arrays. In this case it looks like it was unintentional to concatenate the strings. Separate with a comma. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2557/2719] Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o ../app/test/test_cmdline_ipaddr.c:259:3: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation] "random invalid text", ^ ../app/test/test_cmdline_ipaddr.c:258:3: note: place parentheses around the string literal to silence warning "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234" ^ Signed-off-by: Kevin Traynor --- v2: updated commit msg --- app/test/test_cmdline_ipaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c index b3f50d80d2..2a1ee120fc 100644 --- a/app/test/test_cmdline_ipaddr.c +++ b/app/test/test_cmdline_ipaddr.c @@ -256,5 +256,5 @@ const char * ipaddr_invalid_strs[] = { /* too long */ - "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234" + "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234", "random invalid text", "",