[v2,1/2] net/iavf: fix missing set primary MAC type when start port
Checks
Commit Message
When start port, all MAC addresses will be set. We should set the MAC
type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
v2:
-fix commit message typo
---
drivers/net/iavf/iavf_vchnl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Robin Zhang
> Sent: Wednesday, April 28, 2021 4:05 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type
> when start port
>
> When start port, all MAC addresses will be set. We should set the MAC type of
> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
>
> Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add)
continue;
rte_memcpy(list->list[j].addr, addr->addr_bytes,
sizeof(addr->addr_bytes));
- list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA;
+ list->list[j].type = (j == 0 ?
+ VIRTCHNL_ETHER_ADDR_PRIMARY :
+ VIRTCHNL_ETHER_ADDR_EXTRA);
PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
addr->addr_bytes[0], addr->addr_bytes[1],
addr->addr_bytes[2], addr->addr_bytes[3],