| Message ID | 20210713133542.3550525-2-radu.nicolau@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | akhil goyal |
| Headers | show |
| Series | new features for ipsec and security libraries | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
> Allow user to provision a per security session maximum segment size > (MSS) for use when Transmit Segmentation Offload (TSO) is supported. > The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG > ol_flags are specified in mbuf. > > Signed-off-by: Declan Doherty <declan.doherty@intel.com> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> > Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com> > Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com> > --- Can we have deprecation notice for the changes introduced in this series. Also there are 2 other features which modify same struct. Can we have a Single deprecation notice for all the changes in the rte_security_ipsec_sa_options? The notice can be something like: +* security: The IPsec SA config options structure ``struct rte_security_ipsec_sa_options`` + will be updated to support more features. And we may have a reserved bit fields for rest of the vacant bits so that ABI is not broken When a new bit field is added. http://patches.dpdk.org/project/dpdk/patch/20210630112049.3747-1-marchana@marvell.com/ http://patches.dpdk.org/project/dpdk/patch/20210705131335.21070-1-ktejasree@marvell.com/
Hi, thanks for reviewing. I'm OOO at the moment, I will send an updated patchset next week. On 7/27/2021 9:34 PM, Akhil Goyal wrote: >> Allow user to provision a per security session maximum segment size >> (MSS) for use when Transmit Segmentation Offload (TSO) is supported. >> The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG >> ol_flags are specified in mbuf. >> >> Signed-off-by: Declan Doherty <declan.doherty@intel.com> >> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> >> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com> >> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com> >> --- > Can we have deprecation notice for the changes introduced in this series. > > Also there are 2 other features which modify same struct. Can we have a > Single deprecation notice for all the changes in the rte_security_ipsec_sa_options? > The notice can be something like: > +* security: The IPsec SA config options structure ``struct rte_security_ipsec_sa_options`` > + will be updated to support more features. > And we may have a reserved bit fields for rest of the vacant bits so that ABI is not broken > When a new bit field is added. > > http://patches.dpdk.org/project/dpdk/patch/20210630112049.3747-1-marchana@marvell.com/ > http://patches.dpdk.org/project/dpdk/patch/20210705131335.21070-1-ktejasree@marvell.com/
> > Allow user to provision a per security session maximum segment size > > (MSS) for use when Transmit Segmentation Offload (TSO) is supported. > > The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG > > ol_flags are specified in mbuf. > > > > Signed-off-by: Declan Doherty <declan.doherty@intel.com> > > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> > > Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com> > > Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com> > > --- > Can we have deprecation notice for the changes introduced in this series. > > Also there are 2 other features which modify same struct. Can we have a > Single deprecation notice for all the changes in the > rte_security_ipsec_sa_options? > The notice can be something like: > +* security: The IPsec SA config options structure ``struct > rte_security_ipsec_sa_options`` > + will be updated to support more features. > And we may have a reserved bit fields for rest of the vacant bits so that ABI is > not broken > When a new bit field is added. > > http://patches.dpdk.org/project/dpdk/patch/20210630112049.3747-1- > marchana@marvell.com/ > http://patches.dpdk.org/project/dpdk/patch/20210705131335.21070-1- > ktejasree@marvell.com/ I have sent the consolidated deprecation notice for all three features. Can you guys Ack it? https://mails.dpdk.org/archives/dev/2021-July/215906.html Also, please send deprecation notice for changes in ipsec xform as well.
diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index 88d31de0a6..45896a77d0 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -181,6 +181,19 @@ struct rte_security_ipsec_sa_options { * * 0: Disable per session security statistics collection for this SA. */ uint32_t stats : 1; + + /** Transmit Segmentation Offload (TSO) + * + * * 1: Enable per session security TSO support, use MSS value provide + * in IPsec security session when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG + * ol_flags are set in mbuf. + * this SA, if supported by the driver. + * * 0: No TSO support for offload IPsec packets. Hardware will not + * attempt to segment packet, and packet transmission will fail if + * larger than MTU of interface + */ + uint32_t tso : 1; + }; /** IPSec security association direction */ @@ -217,6 +230,8 @@ struct rte_security_ipsec_xform { /**< Anti replay window size to enable sequence replay attack handling. * replay checking is disabled if the window size is 0. */ + uint32_t mss; + /**< IPsec payload Maximum Segment Size */ }; /**