From patchwork Mon Jul 26 13:58:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 96289 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86E94A0C47; Mon, 26 Jul 2021 15:58:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 536B9410F1; Mon, 26 Jul 2021 15:58:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id EB844410F1 for ; Mon, 26 Jul 2021 15:58:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16QDuHB8006337; Mon, 26 Jul 2021 06:58:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=inTZjsa2KrqVbQ8CR5w7akkuleECRORRuUKDaZ5ulIQ=; b=SS+PnBgD3Uy21Uu1pZ0q4m7tDdk7X6nG8eOYQ9cEJLJcjzDD0+5Nkf2yH/JSl7LaZCTl pJi5Ym+rpscDwIhsZZjtXnE9g4GEupTWsU3SgNmimZI81jCcOBa6gapXzyVJ6CnnFsBc DyHApdd0QEuaaBRFWUrceiGiCAMNQjsCXquk6blxarskIHxPB6MCvs0/7O9rr5jL7VIk qx8HyYWnAZhBzyK2nly5rzVPv5qwO4mVto/GFiWJeVsqFnrVuSJR9UI4/xl03mClSExr kVeZm2dyGSgbG+Pmxw6vcwlwnyqgDRXe3tzDDXUaWtyjmBt4G9FZ4w1WnsvjdgcyjF9g Hw== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3a1m961uqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 26 Jul 2021 06:58:43 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 26 Jul 2021 06:58:40 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 26 Jul 2021 06:58:40 -0700 Received: from localhost.localdomain (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 6B1553F707B; Mon, 26 Jul 2021 06:58:38 -0700 (PDT) From: Tomasz Duszynski To: , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , Tomasz Duszynski Date: Mon, 26 Jul 2021 08:58:10 -0500 Message-ID: <20210726135815.81201-2-tduszynski@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210726135815.81201-1-tduszynski@marvell.com> References: <20210726135815.81201-1-tduszynski@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: jBD1Ng5990LcdJ-znR0EmpUBZ_u3hdVe X-Proofpoint-GUID: jBD1Ng5990LcdJ-znR0EmpUBZ_u3hdVe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-26_06:2021-07-26, 2021-07-26 signatures=0 Subject: [dpdk-dev] [PATCH 1/6] common/cnxk: return saner error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If particular LMAC does not exist then it's saner to return ENODEV instead of EINVAL. Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/roc_bphy_cgx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_bphy_cgx.c b/drivers/common/cnxk/roc_bphy_cgx.c index 9e53fe238e..7449cbe77a 100644 --- a/drivers/common/cnxk/roc_bphy_cgx.c +++ b/drivers/common/cnxk/roc_bphy_cgx.c @@ -406,7 +406,7 @@ roc_bphy_cgx_fec_set(struct roc_bphy_cgx *roc_cgx, unsigned int lmac, return -EINVAL; if (!roc_bphy_cgx_lmac_exists(roc_cgx, lmac)) - return -EINVAL; + return -ENODEV; scr1 = FIELD_PREP(SCR1_ETH_CMD_ID, ETH_CMD_SET_FEC) | FIELD_PREP(SCR1_ETH_SET_FEC_ARGS, fec); @@ -425,7 +425,7 @@ roc_bphy_cgx_fec_supported_get(struct roc_bphy_cgx *roc_cgx, unsigned int lmac, return -EINVAL; if (!roc_bphy_cgx_lmac_exists(roc_cgx, lmac)) - return -EINVAL; + return -ENODEV; scr1 = FIELD_PREP(SCR1_ETH_CMD_ID, ETH_CMD_GET_SUPPORTED_FEC);