diff mbox series

app/test: quieten noise while forking

Message ID 20210801175325.12163-1-john.levon@nutanix.com (mailing list archive)
State Accepted, archived
Headers show
Series app/test: quieten noise while forking | expand

Checks

Context Check Description
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

John Levon Aug. 1, 2021, 5:53 p.m. UTC
When closing file descriptors post-fork, ignore "." and ".." directory
entries, so the test log doesn't have distracting errors like:

Error converting name fd 0 .:
Error converting name fd 0 ..:

Signed-off-by: John Levon <john.levon@nutanix.com>
---
 app/test/process.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Monjalon Aug. 2, 2021, 11:22 a.m. UTC | #1
01/08/2021 19:53, John Levon:
> When closing file descriptors post-fork, ignore "." and ".." directory
> entries, so the test log doesn't have distracting errors like:
> 
> Error converting name fd 0 .:
> Error converting name fd 0 ..:
> 
> Signed-off-by: John Levon <john.levon@nutanix.com>

Applied, thanks.

For info, when sending a new version (in future),
please add a number with the option -v (-v2 in this case).
diff mbox series

Patch

diff --git a/app/test/process.h b/app/test/process.h
index 0ed91a939e..5b10cf64df 100644
--- a/app/test/process.h
+++ b/app/test/process.h
@@ -90,6 +90,11 @@  process_dup(const char *const argv[], int numargs, const char *env_value)
 			}
 
 			while ((dirent = readdir(dir)) != NULL) {
+
+				if (strcmp(dirent->d_name, ".") == 0 ||
+					strcmp(dirent->d_name, "..") == 0)
+					continue;
+
 				errno = 0;
 				fd = strtol(dirent->d_name, &endptr, 10);
 				if (errno != 0 || endptr[0] != '\0') {