[2/2] app/testpmd: fix verbose mode dump for Tx
Checks
Commit Message
Fix verbose mode dump for Tx to dump tx offload flags instead of
Rx offload flags.
Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate function")
Cc: rasland@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
app/test-pmd/util.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Sent: Monday, August 16, 2021 15:10
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; rasland@mellanox.com; stable@dpdk.org
> Subject: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
>
> Fix verbose mode dump for Tx to dump tx offload flags instead of Rx offload
> flags.
>
> Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate
> function")
> Cc: rasland@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
> app/test-pmd/util.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 5dd7157..14a9a25
> 100644
> --- a/app/test-pmd/util.c
> +++ b/app/test-pmd/util.c
> @@ -275,7 +275,11 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue,
> struct rte_mbuf *pkts[],
> " - %s queue=0x%x", is_rx ? "Receive" : "Send",
> (unsigned int) queue);
> MKDUMPSTR(print_buf, buf_size, cur_len, "\n");
> - rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
> + if (is_rx)
> + rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
> + else
> + rte_get_tx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
> +
> MKDUMPSTR(print_buf, buf_size, cur_len,
> " ol_flags: %s\n", buf);
> if (rte_mbuf_check(mb, 1, &reason) < 0)
> --
> 2.8.4
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Hi,
> -----Original Message-----
> From: Li, Xiaoyun <xiaoyun.li@intel.com>
> Sent: Tuesday, August 17, 2021 4:54 AM
> To: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Cc: jerinj@marvell.com; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
>
>
>
> > -----Original Message-----
> > From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Sent: Monday, August 16, 2021 15:10
> > To: Li, Xiaoyun <xiaoyun.li@intel.com>
> > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram
> > <ndabilpuram@marvell.com>; rasland@mellanox.com; stable@dpdk.org
> > Subject: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
> >
> > Fix verbose mode dump for Tx to dump tx offload flags instead of Rx
> offload
> > flags.
> >
> > Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate
> > function")
> > Cc: rasland@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> > app/test-pmd/util.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index
> 5dd7157..14a9a25
> > 100644
> > --- a/app/test-pmd/util.c
> > +++ b/app/test-pmd/util.c
> > @@ -275,7 +275,11 @@ dump_pkt_burst(uint16_t port_id, uint16_t
> queue,
> > struct rte_mbuf *pkts[],
> > " - %s queue=0x%x", is_rx ? "Receive" : "Send",
> > (unsigned int) queue);
> > MKDUMPSTR(print_buf, buf_size, cur_len, "\n");
> > - rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
> > + if (is_rx)
> > + rte_get_rx_ol_flag_list(mb->ol_flags, buf,
> sizeof(buf));
> > + else
> > + rte_get_tx_ol_flag_list(mb->ol_flags, buf,
> sizeof(buf));
> > +
> > MKDUMPSTR(print_buf, buf_size, cur_len,
> > " ol_flags: %s\n", buf);
> > if (rte_mbuf_check(mb, 1, &reason) < 0)
> > --
> > 2.8.4
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Raslan Darawsheh <rasland@nvidia.com>
Kindest regards,
Raslan Darawsheh
@@ -275,7 +275,11 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
" - %s queue=0x%x", is_rx ? "Receive" : "Send",
(unsigned int) queue);
MKDUMPSTR(print_buf, buf_size, cur_len, "\n");
- rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
+ if (is_rx)
+ rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
+ else
+ rte_get_tx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
+
MKDUMPSTR(print_buf, buf_size, cur_len,
" ol_flags: %s\n", buf);
if (rte_mbuf_check(mb, 1, &reason) < 0)