From patchwork Tue Aug 17 13:44:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 97008 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8804A0548; Tue, 17 Aug 2021 15:47:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5507941288; Tue, 17 Aug 2021 15:45:48 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2043.outbound.protection.outlook.com [40.107.236.43]) by mails.dpdk.org (Postfix) with ESMTP id E12A041277 for ; Tue, 17 Aug 2021 15:45:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxKzlhTT09TWCb2n7c56F8mcYO8NaNQQhTZ+rfVC7rVJswLGg/vpqrIp88/O5fmZ/4bHAqAUtT0/sWEaPf+hMiCPi0TqRuiN2FOh1mqZ4JW8yx7tBn2SEIKjC+RfoLYc2jk7kgxZ8FdV5sCBNlumdk4W+/fAkGABFGx4jYHa1aC3iB9zSFz9Y1sTAgKIH8/bOXUSFKT/cZKFmPckY0HlcMAv9XrlkftuMwnAjW4gegb3cJo83EhbiFYpkHOZ8rRQd7GJWiZl9/VYBxx3skBa0YRZp/fPoOs9lYffN5977RGephRmaGik/kjm2fPkPgzrm0n+Jtb4/JmOJpV/U8+aaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JA/I5BI8i9nKfn05OwQURCZ8RDugY/ckn3lIF/l/r5k=; b=X/BbrPIREmrYwh2Zmn3B/3O3mfHZnNZqtuD836MWp3izTMEu5l7P5Jz+0SGBoRxuXm6a8F7JVGXwajZ+wq2+GeE+HzNVv0oZfH6+heaa6guaBsh5ZSltSclZfYSPFg1wd1AKWA/E8H9JLczJtpdTtE1QIB6zQQHEa/G7ltw8Y4JsThxWLvi2XNbbcx5f//A7FNg7PoMAiai3rE69ca29lo9cZctQHitOk8yoCf2ASx0KYR3UvUBBdRhhD295FYkpPsKcJHTIqIHIbXC2KE3q4jZpFs1ZmolPsR3r000F+ck9xGENUYGOfK4s/yrtkq4renEt3ZqsFGEVDMr4EE2L6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JA/I5BI8i9nKfn05OwQURCZ8RDugY/ckn3lIF/l/r5k=; b=cAVOsd0tsHM7NiBk/W0/tW2GuQaduTUSczBD0/+Vceki9ZXdjGgOX3NDSFsHcBTLW+GQzCS9IUP0Cg8FIdOGreG15wTxLF+4yHZuzKncDdNRYBL/juNJUfwDdM77oaIK03ci9RfZV73l7VZAfIA1C/gQvfjnW4uUijdqz1+mBY7ach4hUSi6XQ8z6xuk8sKBYrGBsdrV/omQGry0RPIReLfOt8MJb6Cvu4WqiRVPbaWLhOzULjB+hfmxnZ+aPF7yFy3CV+jEHokp4eMjX6MjwlesS75+bNQ0B3YxuFRdK/Z0eY0BR208jMf7HaqK0fHPxAWUEYMMAefE0K56Vonntw== Received: from BN9PR03CA0573.namprd03.prod.outlook.com (2603:10b6:408:10d::8) by DM6PR12MB4385.namprd12.prod.outlook.com (2603:10b6:5:2a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 17 Aug 2021 13:45:44 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::37) by BN9PR03CA0573.outlook.office365.com (2603:10b6:408:10d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 13:45:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.16 via Frontend Transport; Tue, 17 Aug 2021 13:45:44 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:43 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:42 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Tue, 17 Aug 2021 16:44:38 +0300 Message-ID: <20210817134441.1966618-19-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817134441.1966618-1-michaelba@nvidia.com> References: <20210817134441.1966618-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aace5e15-6b91-4395-96dc-08d961854f97 X-MS-TrafficTypeDiagnostic: DM6PR12MB4385: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pr+HXocrtmJEkWq+Ro/eKgQyaONjyr0EA74eH6XEGzPWaPsYHa5ISwUVnWX5DDc9GP5p3EkaMFN/c1MkxEnysmVZ7Uez4VF/M7rgZL5G5v97gaOgKpzCms5hTKKYQArF4CBCuRsuyLkc0D6ugc2UbeV5D0aqVwRWP7NWYyHWdkun7orjTaXbRxc7JrXFYmLB56d75JeWWQyAT7Mv6TwSHmrC1nnrlVcJaTTDdTb9ezvyHXSEPS5dW3jVoRKz2dlKHxKbj8VigdvOK42twJBXhcoy3NIjOSNkh8cm6ciS7XSdHxRxxJG4lztKrm35DktllvvJBzLj3biQOL9JhJml+dcDQIpqpan5CMx/lzK2pj382/13CX9j+SiUMYT9O1S9S9HQwwBM5Ggh+v5l62xrqhBKiSmAj6aIjJ8Yehijm55lOSfDfd54NOUvIRn1NzHQNxkqbA7T0TWUUbf2GcjdJiekjbC20gIUwCgVMfZoQrWz2Y2z3pE0RWYrXSZJlptFpqz/JOYP/L/O1QECJWQYB1O+Krvc1ZwFsQzLyiqE/tbYH3kEVF7M7AcEn7zhgBS5wz92Pce1ogKTp4HK7pUgpCa8Njk6iYMVGLg1VnDnCRj2A+jVqyKFxQWd5Fi7Yw8RnebORfCOteSnApFVSIdZbI9lh0YyfoS9D16qfYfpX6S78h2nai+AE+e1stwIYKD64rkbDLbxZeFNQ9I3NRM92A== X-Forefront-Antispam-Report: CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(83380400001)(7696005)(4326008)(70206006)(6286002)(5660300002)(55016002)(356005)(316002)(426003)(186003)(36860700001)(6666004)(8676002)(36756003)(6916009)(70586007)(8936002)(7636003)(107886003)(54906003)(47076005)(1076003)(336012)(26005)(508600001)(16526019)(86362001)(82310400003)(2906002)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:45:44.1955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aace5e15-6b91-4395-96dc-08d961854f97 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4385 Subject: [dpdk-dev] [RFC 18/21] vdpa/mlx5: use HCA attributes from context device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/vdpa/mlx5/mlx5_vdpa.c | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 2b1b521313..317d2e8ed4 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -506,36 +506,24 @@ static int mlx5_vdpa_dev_probe(struct mlx5_common_device *dev) { struct mlx5_vdpa_priv *priv = NULL; - struct mlx5_hca_attr attr; - int ret; + struct mlx5_hca_attr *attr = &dev->ctx.hca_attr; - ret = mlx5_devx_cmd_query_hca_attr(dev->ctx.ctx, &attr); - if (ret) { - DRV_LOG(ERR, "Unable to read HCA capabilities."); - rte_errno = ENOTSUP; - return -rte_errno; - } else if (!attr.vdpa.valid || !attr.vdpa.max_num_virtio_queues) { - DRV_LOG(ERR, "Not enough capabilities to support vdpa, maybe " - "old FW/OFED version?"); - rte_errno = ENOTSUP; - return -rte_errno; - } - if (!attr.vdpa.queue_counters_valid) + if (!attr->vdpa.queue_counters_valid) DRV_LOG(DEBUG, "No capability to support virtq statistics."); priv = rte_zmalloc("mlx5 vDPA device private", sizeof(*priv) + sizeof(struct mlx5_vdpa_virtq) * - attr.vdpa.max_num_virtio_queues * 2, + attr->vdpa.max_num_virtio_queues * 2, RTE_CACHE_LINE_SIZE); if (!priv) { DRV_LOG(ERR, "Failed to allocate private memory."); rte_errno = ENOMEM; return -rte_errno; } - priv->caps = attr.vdpa; - priv->log_max_rqt_size = attr.log_max_rqt_size; - priv->num_lag_ports = attr.num_lag_ports; - priv->qp_ts_format = attr.qp_ts_format; - if (attr.num_lag_ports == 0) + priv->caps = attr->vdpa; + priv->log_max_rqt_size = attr->log_max_rqt_size; + priv->num_lag_ports = attr->num_lag_ports; + priv->qp_ts_format = attr->qp_ts_format; + if (attr->num_lag_ports == 0) priv->num_lag_ports = 1; priv->dev_ctx = &dev->ctx; priv->var = mlx5_glue->dv_alloc_var(priv->dev_ctx->ctx, 0);