From patchwork Tue Aug 17 13:44:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 97012 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3A5DA0548; Tue, 17 Aug 2021 15:48:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3E614129F; Tue, 17 Aug 2021 15:45:53 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2087.outbound.protection.outlook.com [40.107.236.87]) by mails.dpdk.org (Postfix) with ESMTP id CC12041294 for ; Tue, 17 Aug 2021 15:45:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8/UhzekY5dSNwd4YgZRBWzg1wh/Q7n95xkysCHvbGGC/ivwClRcGRrOPj+rdKWCziWD+00OmeWj/4pAAFIipETAUVeLzEUoS2LshINgqKgeZ3G9yD1dikopb59qa3+ICjVa6CjSmW2w67FHzZr7HS1G9vPshJB1XpEft1MjvXVCcpHkjj/u4qXrZmnFTpaQb66NDlQ77e4WpXIgnmRbhhhAT6AhBpAO4GmXGmT9PysGai3sKISmW0th16qKCdDn+1ocOfe4a+LG9eIRhiqp/pwe7FvXeabGVpUMrqjhdeSNXYDH8y0dntGCUOcoK8oYXhDi79x7MQWq+3QySEfSTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mFdk9nXG1pXqvcXcigwBl2Am+JVuyhkcWJDZFCmEHo=; b=PFxmOLf1PqyOAyg6SJrc1R0Y2hvMfvi2sepxy3Rbgj4ghGrWIKKchJKTyhT2tOyJYizqRhh/+rkc/eYbpMGv4Jcop9q4l3KVosj9xGqAGr49AIQGk4ZB1PosjzF+cr9kJKVnIO0352s5NRQ078xNk4eoNw7/E7mUzEu3E82Xm8o1ncJvXWMHHkrppozclfjf/BD8P7///rEwnQiZSvJUbrW/1QeHu90ClgIyeoc2ctOEfvF9+aDTolcHeKVoEvtK8JLEJQXA4KcMKYd/AxL6/EMvbXwjtxKP+lPKZxv7UiFxfh9qE98wCqtmSdpOR03x2ldSWnj6n06gviqt9KZ29A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mFdk9nXG1pXqvcXcigwBl2Am+JVuyhkcWJDZFCmEHo=; b=jen3XKl5o4wsiDdE8Y49p6dJwrbCU7waRepQruKN4c6Drx4Lv/PHx95GFbZb95ve6zsErY/7OdtPdclMrIDqkiYXYAzqGoSMVTjAeRALhjhbWqlWDim55E+vuIybL5ToFKlQeXgRPz0h4tuc9tcUfnCp61w+mqXGepJ9zp5F91A1GgQ/1btqI7XsSgAzAn1AG/+9ejXmEf+RI2dFS3oapDpVzhSEvuATio2dziUt9RbmDEoD9Wx+a+Ha98V0+e6kddOoiqyKCJzQgXCx1Fy01ba/tGIKzcy2U4xooOE57UXpKfS16/GE+EZlGkVo6F9aGCTf9pvfA9TkTeOdwbsPag== Received: from MW4PR04CA0382.namprd04.prod.outlook.com (2603:10b6:303:81::27) by DM6PR12MB2906.namprd12.prod.outlook.com (2603:10b6:5:15f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Tue, 17 Aug 2021 13:45:49 +0000 Received: from CO1NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::59) by MW4PR04CA0382.outlook.office365.com (2603:10b6:303:81::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 13:45:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by CO1NAM11FT042.mail.protection.outlook.com (10.13.174.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:48 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 06:45:47 -0700 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:45 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Tue, 17 Aug 2021 16:44:40 +0300 Message-ID: <20210817134441.1966618-21-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817134441.1966618-1-michaelba@nvidia.com> References: <20210817134441.1966618-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1de3326a-393b-4909-5614-08d961855255 X-MS-TrafficTypeDiagnostic: DM6PR12MB2906: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gC/zYuCwgFDaDu6MdRDYx/6T3Fbtu3BnOSdto1mo/diJq/GBzF/sXwAmSrmXZXSvdLUXjoDyA2LDEAR2VvNNzZco7Kx+7HESzIU003BxAwWmIe2M7H4DxhMd4bhcQVsJ+VU+AQRL436ltPa1Tpgasw8jY6i5qUoxPw75s4pjXTPfBfqg005wBwxzS8gTSForM7vxv2XvXZLthV5R9rmaN8JsxzuqM6c/a4L/Wqm73lsEj80ff1PE4azZO76IS9CSLvoVjsfNNaxPi42Wcu3tbAoss9/IP4vbI+ObsQlI4gpRfAY+NZTgH3N5G7TDMIYK9XvSviAys2naYqdGebujw8WDUgf8EaHs8CVEXINsyDyN/r4fFXafKrmwvmkMIN9PguVeSGHDYgvKikLHMkAOlLgreEIeAsZuRyACCzHER3QY2cguI+tMp6iCSfLgB3Yl4a6+wHyhExU2Bg6VJiLTLvwYocqo+SyR1qzdMUh77UvxaAy5yX+d8GyzKb87ECeO85L6qjDzgxlWi5Q4B5KmaWAkyiCpXzXneniWf+GO6q0QbnueN2ECvNtkEuP1OyvFEpoB0Qr1EUtsLGx2St0/7w2DSlR3kGP7dJK8cJgxpIxjXcWE7EwY+9fceRqyGZ2/zjCEDvuNgoe8Qum5ZfAVVpk4LpC1ZSsmyUzLwxFGUpj3L86qeNgENEtl8RCmwZ1wqfCp+g1Enau2G9Ri13eb1A== X-Forefront-Antispam-Report: CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8676002)(6916009)(316002)(2616005)(8936002)(7696005)(508600001)(26005)(1076003)(54906003)(5660300002)(36756003)(426003)(336012)(36860700001)(83380400001)(107886003)(70586007)(6666004)(47076005)(55016002)(82310400003)(7636003)(2906002)(186003)(4326008)(356005)(6286002)(86362001)(70206006)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:45:48.7935 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1de3326a-393b-4909-5614-08d961855255 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2906 Subject: [dpdk-dev] [RFC 20/21] crypto/mlx5: use HCA attributes from context device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/crypto/mlx5/mlx5_crypto.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 4f390c8bf4..734ca63d89 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -949,7 +949,6 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *dev) struct mlx5_devx_obj *login; struct mlx5_crypto_priv *priv; struct mlx5_crypto_devarg_params devarg_prms = { 0 }; - struct mlx5_hca_attr attr = { 0 }; struct rte_cryptodev_pmd_init_params init_params = { .name = "", .private_data_size = sizeof(struct mlx5_crypto_priv), @@ -966,13 +965,6 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *dev) rte_errno = ENOTSUP; return -rte_errno; } - if (mlx5_devx_cmd_query_hca_attr(dev_ctx->ctx, &attr) != 0 || - attr.crypto == 0 || attr.aes_xts == 0) { - DRV_LOG(ERR, "Not enough capabilities to support crypto " - "operations, maybe old FW/OFED version?"); - rte_errno = ENOTSUP; - return -ENOTSUP; - } ret = mlx5_crypto_parse_devargs(dev->dev->devargs, &devarg_prms); if (ret) { DRV_LOG(ERR, "Failed to parse devargs.");