test/service_cores: fix wrong comment
Checks
Commit Message
Change the inaccurate comment of 'set pass flag'
to 'clear pass flag' as the '*pass_test = 0' code
actually implements clearing.
Fixes: f038a81e1c56 ("service: add unit tests")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_service_cores.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Joyce Kong <joyce.kong@arm.com>
> Sent: Thursday, August 19, 2021 7:11 AM
> To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com;
> ruifeng.wang@arm.com
> Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org
> Subject: [PATCH] test/service_cores: fix wrong comment
>
> Change the inaccurate comment of 'set pass flag'
> to 'clear pass flag' as the '*pass_test = 0' code
> actually implements clearing.
>
> Fixes: f038a81e1c56 ("service: add unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
On Thu, Aug 19, 2021 at 10:13 AM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
>
> > -----Original Message-----
> > From: Joyce Kong <joyce.kong@arm.com>
> > Sent: Thursday, August 19, 2021 7:11 AM
> > To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com;
> > ruifeng.wang@arm.com
> > Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org
> > Subject: [PATCH] test/service_cores: fix wrong comment
> >
> > Change the inaccurate comment of 'set pass flag'
> > to 'clear pass flag' as the '*pass_test = 0' code
> > actually implements clearing.
> >
> > Fixes: f038a81e1c56 ("service: add unit tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks.
@@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args)
rte_delay_ms(250);
__atomic_store_n(lock, 0, __ATOMIC_RELAXED);
} else {
- /* 2nd thread will fail to take lock, so set pass flag */
+ /* 2nd thread will fail to take lock, so clear pass flag */
*pass_test = 0;
}