diff mbox series

[36/38] net/sfc: use switch port ID as representor ID

Message ID	20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: dev@dpdk.org Cc: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>, Andy Moreton <amoreton@xilinx.com> Date: Fri, 27 Aug 2021 09:57:15 +0300 Message-Id: <20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru> References: <20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 36/38] net/sfc: use switch port ID as representor ID Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	net/sfc: support port representors \| [00/38] net/sfc: support port representors [01/38] common/sfc_efx/base: update MCDI headers [02/38] common/sfc_efx/base: update EF100 registers definitions [03/38] net/sfc: add switch mode device argument [04/38] net/sfc: insert switchdev mode MAE rules [05/38] common/sfc_efx/base: add an API to get mport ID by selector [06/38] net/sfc: support EF100 Tx override prefix [07/38] net/sfc: add representors proxy infrastructure [08/38] net/sfc: reserve TxQ and RxQ for port representors [09/38] net/sfc: move adapter state enum to separate header [10/38] common/sfc_efx/base: allow creating invalid mport selectors [11/38] net/sfc: add port representors infrastructure [12/38] common/sfc_efx/base: add filter ingress mport matching field [13/38] common/sfc_efx/base: add API to get mport selector by ID [14/38] common/sfc_efx/base: add mport alias MCDI wrappers [15/38] net/sfc: add representor proxy port API [16/38] net/sfc: implement representor queue setup and release [17/38] net/sfc: implement representor RxQ start/stop [18/38] net/sfc: implement representor TxQ start/stop [19/38] net/sfc: implement port representor start and stop [20/38] net/sfc: implement port representor link update [21/38] net/sfc: support multiple device probe [22/38] net/sfc: implement representor Tx routine [23/38] net/sfc: use xword type for EF100 Rx prefix [24/38] net/sfc: handle ingress m-port in EF100 Rx prefix [25/38] net/sfc: implement representor Rx routine [26/38] net/sfc: add simple port representor statistics [27/38] net/sfc: free MAE lock once switch domain is assigned [28/38] common/sfc_efx/base: add multi-host function M-port selector [29/38] common/sfc_efx/base: retrieve function interfaces for VNICs [30/38] common/sfc_efx/base: add a means to read MAE mport journal [31/38] common/sfc_efx/base: allow getting VNIC MCDI client handles [32/38] net/sfc: maintain controller to EFX interface mapping [33/38] net/sfc: store PCI address for represented entities [34/38] net/sfc: include controller and port in representor name [35/38] net/sfc: support new representor parameter syntax [36/38] net/sfc: use switch port ID as representor ID [37/38] net/sfc: implement the representor info API [38/38] net/sfc: update comment about representor support

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Andrew Rybchenko Aug. 27, 2021, 6:57 a.m. UTC

From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>

Representor IDs must be unique for each representor. VFs, which are
currently used, are not unique as they may repeat in combination with
different PCI controllers and PFs. On the other hand, switch port IDs
are unique, so they are a better fit for this role.

Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
 drivers/net/sfc/sfc_repr.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index d50efe6562..4cbfdbcb66 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -921,7 +921,6 @@  static const struct eth_dev_ops sfc_repr_dev_ops = {
 
 struct sfc_repr_init_data {
 	uint16_t		pf_port_id;
-	uint16_t		repr_id;
 	uint16_t		switch_domain_id;
 	efx_mport_sel_t		mport_sel;
 	efx_pcie_interface_t	intf;
@@ -979,7 +978,7 @@  sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)
 	}
 
 	ret = sfc_repr_proxy_add_port(repr_data->pf_port_id,
-				      repr_data->repr_id,
+				      srs->switch_port_id,
 				      dev->data->port_id,
 				      &repr_data->mport_sel);
 	if (ret != 0) {
@@ -1006,7 +1005,7 @@  sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)
 	dev->process_private = sr;
 
 	srs->pf_port_id = repr_data->pf_port_id;
-	srs->repr_id = repr_data->repr_id;
+	srs->repr_id = srs->switch_port_id;
 	srs->switch_domain_id = repr_data->switch_domain_id;
 
 	dev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;
@@ -1034,7 +1033,7 @@  sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)
 
 fail_alloc_sr:
 	(void)sfc_repr_proxy_del_port(repr_data->pf_port_id,
-				      repr_data->repr_id);
+				      srs->switch_port_id);
 
 fail_create_port:
 fail_mae_assign_switch_port:
@@ -1087,7 +1086,6 @@  sfc_repr_create(struct rte_eth_dev *parent,
 	if (dev == NULL) {
 		memset(&repr_data, 0, sizeof(repr_data));
 		repr_data.pf_port_id = parent->data->port_id;
-		repr_data.repr_id = entity->vf;
 		repr_data.switch_domain_id = switch_domain_id;
 		repr_data.mport_sel = *mport_sel;
 		repr_data.intf = entity->intf;