From patchwork Mon Aug 30 14:27:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Ryzhov X-Patchwork-Id: 97555 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF396A034F; Mon, 30 Aug 2021 16:27:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E12D4111E; Mon, 30 Aug 2021 16:27:39 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id 4E811410FC for ; Mon, 30 Aug 2021 16:27:35 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id l2so23526842lfp.2 for ; Mon, 30 Aug 2021 07:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tzOEu8/g9NHoVjhaT5GbQFAUYdTV9TiEty8W0TRL0Ks=; b=VHiaW2vkCD67MbkGEKHwmOE/hylda4eTlOJY2z16Z+RJi72narcP1F9ub392rFDVhT YpXGQ6JKM/okGUVnDKfBBNgc/FANVCPmj7xefRkXDCQAND6RleSRE0mOg4UEvYL1VeUn DLQF7uZRsmX570Qo6AvhgUnJF2NVtaUBkE++t3+waaKF6z7rXceoYyS65ZlexT+SILVC 90RSp9ZGLNKSVhtPB98wyMgaO2vDLtTs1NcS1Fymyv2SMTfWXONMPWvPF85XnR71YOEr iT81NL46DKgvvwR0KpZne+C2Qnd0WvzXRZigQ9DqHHhPIYqJim8mUJt6OMSHX8psphsd mCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tzOEu8/g9NHoVjhaT5GbQFAUYdTV9TiEty8W0TRL0Ks=; b=Nz4tAKxfPdoGd5OlrbajEvdtEr/FCGS6npSY/hvlTdtRicF6oUkUDOMEzivQXub9m8 va0Zz1HL4s5bTvMf3EqLWXJxPsjCOR6c0wLlcyD8otcBjsRGdT1G8MpacLuutqq7h18A vM599kXD9mQYOj7YHKr8UWARWwVoIU+nvDzQ/qqLzJUCNpQr5dFX1bV8ARV1TRoN8MUI /XQV4b7jOOZrSY82JUw6/gZFAtsCjBTZyjtd6Kfox6B0lElxe6HQYdbcy1pldYQ1jGyf G926PydItp7iId1syK5g7AAkoLSxqUxxZuWXN7f5vT2vQ+gVIb8ELIqKFWojMVeu7EAr /K+g== X-Gm-Message-State: AOAM533KhweN5CapjIhTNYUAlZqUR3ZtW5ZqXt33ayuQICng5JUnOy6h wti2yS1P3jX0efVIIscE4X4t6GJotQ/gWA== X-Google-Smtp-Source: ABdhPJw1Qse3btAdWyUsb0O3gqaRQHoxorwmaFAX1Y0oo/GtPnKe2kZcg04jd9T1WfkbsmUTCVhn2Q== X-Received: by 2002:ac2:5c4c:: with SMTP id s12mr16701197lfp.108.1630333654532; Mon, 30 Aug 2021 07:27:34 -0700 (PDT) Received: from localhost.localdomain ([77.105.181.112]) by smtp.gmail.com with ESMTPSA id p1sm692516lfo.255.2021.08.30.07.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 07:27:33 -0700 (PDT) From: Igor Ryzhov To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Mon, 30 Aug 2021 17:27:31 +0300 Message-Id: <20210830142731.32524-3-iryzhov@nfware.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210830142731.32524-1-iryzhov@nfware.com> References: <20210826151911.15699-1-iryzhov@nfware.com> <20210830142731.32524-1-iryzhov@nfware.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v6 3/3] app/test: fix return value of test_kni_link_change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the child process returns -1, WEXITSTATUS converts to 255 because it takes only 8 least significant bits. As a result, the test is not considered failed when it should. Signed-off-by: Igor Ryzhov --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_kni.c b/app/test/test_kni.c index 0df028696f36..70c81f4af0f4 100644 --- a/app/test/test_kni.c +++ b/app/test/test_kni.c @@ -214,7 +214,7 @@ test_kni_link_change(void) p_ret = waitpid(pid, &status, WNOHANG); if (p_ret != 0) { if (WIFEXITED(status)) - return WEXITSTATUS(status); + return WEXITSTATUS(status) ? -1 : 0; return -1; } rte_delay_ms(10);