net/ixgbe: fix rss max rxtx queue num

Message ID 20210831091111.6879-1-chenqiming_huawei@163.com (mailing list archive)
State Rejected, archived
Delegated to: Qi Zhang
Headers
Series net/ixgbe: fix rss max rxtx queue num |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Qiming Chen Aug. 31, 2021, 9:11 a.m. UTC
  Through the local actual test, it is found that the maximum number of
RSS queues is 16, not 128. Check the chip manual, the register MRQE
has the following description: RSS only-Single set of RSS 16 queues.
It also coincides with the actual test value.

Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
Cc: stable@dpdk.org

Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
 drivers/net/ixgbe/base/ixgbe_82599.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Wang, Haiyue Sept. 6, 2021, 1:31 a.m. UTC | #1
> -----Original Message-----
> From: Qiming Chen <chenqiming_huawei@163.com>
> Sent: Tuesday, August 31, 2021 17:11
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen <chenqiming_huawei@163.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix rss max rxtx queue num
> 
> Through the local actual test, it is found that the maximum number of
> RSS queues is 16, not 128. Check the chip manual, the register MRQE
> has the following description: RSS only-Single set of RSS 16 queues.
> It also coincides with the actual test value.
> 
> Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_82599.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c
> index 69fd4cd3fb..edd63018d1 100644
> --- a/drivers/net/ixgbe/base/ixgbe_82599.c
> +++ b/drivers/net/ixgbe/base/ixgbe_82599.c
> @@ -8,8 +8,8 @@
>  #include "ixgbe_common.h"
>  #include "ixgbe_phy.h"
> 
> -#define IXGBE_82599_MAX_TX_QUEUES 128
> -#define IXGBE_82599_MAX_RX_QUEUES 128
> +#define IXGBE_82599_MAX_TX_QUEUES 16
> +#define IXGBE_82599_MAX_RX_QUEUES 16

Let's keep the value, since there are so many kind of ixgbe,
and sync it with the kernel:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c#n12


>  #define IXGBE_82599_RAR_ENTRIES   128
>  #define IXGBE_82599_MC_TBL_SIZE   128
>  #define IXGBE_82599_VFT_TBL_SIZE  128
> --
> 2.30.1.windows.1
  

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c
index 69fd4cd3fb..edd63018d1 100644
--- a/drivers/net/ixgbe/base/ixgbe_82599.c
+++ b/drivers/net/ixgbe/base/ixgbe_82599.c
@@ -8,8 +8,8 @@ 
 #include "ixgbe_common.h"
 #include "ixgbe_phy.h"
 
-#define IXGBE_82599_MAX_TX_QUEUES 128
-#define IXGBE_82599_MAX_RX_QUEUES 128
+#define IXGBE_82599_MAX_TX_QUEUES 16
+#define IXGBE_82599_MAX_RX_QUEUES 16
 #define IXGBE_82599_RAR_ENTRIES   128
 #define IXGBE_82599_MC_TBL_SIZE   128
 #define IXGBE_82599_VFT_TBL_SIZE  128