[v3,4/4] mbuf: make rte_mbuf_check part of stable API

Message ID 20210831193507.43426-5-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series mbuf: promote experimental API's to stable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Stephen Hemminger Aug. 31, 2021, 7:35 p.m. UTC
  This one has been in for required time period.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/mbuf/rte_mbuf.h  | 1 -
 lib/mbuf/version.map | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
  

Comments

Andrew Rybchenko Sept. 1, 2021, 6:46 a.m. UTC | #1
On 8/31/21 10:35 PM, Stephen Hemminger wrote:
> This one has been in for required time period.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Experimental warning should be removed from the description.

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
  
Andrew Rybchenko Sept. 1, 2021, 6:49 a.m. UTC | #2
On 9/1/21 9:46 AM, Andrew Rybchenko wrote:
> On 8/31/21 10:35 PM, Stephen Hemminger wrote:
>> This one has been in for required time period.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Experimental warning should be removed from the description.

Apologies, there is no experimental warning in the function
description.

> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
  
Olivier Matz Sept. 16, 2021, 12:35 p.m. UTC | #3
On Wed, Sep 01, 2021 at 09:49:06AM +0300, Andrew Rybchenko wrote:
> On 9/1/21 9:46 AM, Andrew Rybchenko wrote:
> > On 8/31/21 10:35 PM, Stephen Hemminger wrote:
> >> This one has been in for required time period.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > 
> > Experimental warning should be removed from the description.
> 
> Apologies, there is no experimental warning in the function
> description.
> 
> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
  

Patch

diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 627790fe26e7..c70330f09dd8 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -536,7 +536,6 @@  rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header);
  *   - -1 if a problem is detected, reason then points to a string describing
  *     the reason why the mbuf is deemed invalid.
  */
-__rte_experimental
 int rte_mbuf_check(const struct rte_mbuf *m, int is_header,
 		   const char **reason);
 
diff --git a/lib/mbuf/version.map b/lib/mbuf/version.map
index b63e28a8cc4d..2745c2b77cc9 100644
--- a/lib/mbuf/version.map
+++ b/lib/mbuf/version.map
@@ -16,6 +16,7 @@  DPDK_22 {
 	rte_get_tx_ol_flag_list;
 	rte_get_tx_ol_flag_name;
 	rte_mbuf_best_mempool_ops;
+	rte_mbuf_check;
 	rte_mbuf_dyn_dump;
 	rte_mbuf_dyn_rx_timestamp_register;
 	rte_mbuf_dyn_tx_timestamp_register;
@@ -45,7 +46,6 @@  DPDK_22 {
 EXPERIMENTAL {
 	global:
 
-	rte_mbuf_check;
 	rte_pktmbuf_pool_create_extbuf;
 
 };