From patchwork Tue Aug 31 20:37:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 97640 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39200A0C58; Tue, 31 Aug 2021 22:38:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37E4541137; Tue, 31 Aug 2021 22:38:08 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by mails.dpdk.org (Postfix) with ESMTP id 25101410FE; Tue, 31 Aug 2021 22:38:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AS+uZKeNMxbYYjv+XHrhcfCFenFzFTqHSWDN4T2klE/PHdT+VuJ0GS2UlfHlkQ61F0ZjCPDLsHrXHs2WMVlOr2DxvkKfHumoHYSmtki1MTb0wpl4Rwa/PAWSw5G+pZV+of9mkugiMwWyuFa6aU3gSrXX2TWvP+3ZuITZAeMe8RfbO5madU7hWCG3kjdDhHoe73a+xSxQ8xMrLl6sqWU0KbgQVrKql5LGcFubZ0JuROWOmgM8FjBoTx4xHMkTW6woWb+eCwZ0+kbBqGNxv5+lLdCMdOIgS0/p5yXPnK1VYBSBd4T6HjDJx0tTEx8CqbDOzrJ/ukiI0N0NERennrhV6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oS2RfLxacUU/TjNvqVboNTabz1CwrTVR2m3daABWZfI=; b=FWXQSs6ilGJYLrA4jXrqHnauV2t9iS4Or4vvPYtgC7pZD8hvYbuqfjqmTLLRCTvxeaSUuBazvcIKTVxsNnWtXnwPF1u2nPgQMVfNBKt7Dr3IR/jJy7AW3jz6EvBwrwFPKa06q4C8FIae+M+AwqsOa//B5FYhRHInlXd9xE2c8dl9Noii9aH+oM1bffKCuIQj088KOZephtXcsxCkyT46yoZxMuMrUDkP0fImh9g/WKXvkNxquDqYLiJUMwrS35xJpJEBQZ9nxqyEn4nTIHmeWB1PcGXXIw5yBicljCEyiUANiCAZg+Mrx9ecmH/n+s6MA6OTL8HCds9WAYERpf/0Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oS2RfLxacUU/TjNvqVboNTabz1CwrTVR2m3daABWZfI=; b=bNWCIUj5LUZPGVvP2uJA9eOmMdmnOjSUBJ5Bssubq2yxJHTiF7BcDXW/DluaDa/i6hpX03jAP7CPfei1hCe+8OFYKpBcpIlr7SuCC3KtkBPM+IUb3eRbaSDiI4LMGi3fmWbXhFyTn3DgIxwHE2bFXGWdkxarB7zKNaWTBU2vxYcAGs1yV5Ansvv9S6XXWK/+5nIBrDgw35+//8lGqvWYil1JaVk/X7VSmkilxaXSHrWKFbvYxVnV7Ggu8uwdBkLNSK7pAKampSLkEHz0Rv1TokAA5SolFXo8T1uwlX2TSFlBbpdcWYZC72H8wH6dNTK8z7a3DJlg2Zq/7uSNB/XxlQ== Received: from MW4PR04CA0334.namprd04.prod.outlook.com (2603:10b6:303:8a::9) by PH0PR12MB5417.namprd12.prod.outlook.com (2603:10b6:510:e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Tue, 31 Aug 2021 20:38:02 +0000 Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::36) by MW4PR04CA0334.outlook.office365.com (2603:10b6:303:8a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21 via Frontend Transport; Tue, 31 Aug 2021 20:38:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT033.mail.protection.outlook.com (10.13.174.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 31 Aug 2021 20:38:02 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 20:38:01 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 20:38:00 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Tue, 31 Aug 2021 23:37:29 +0300 Message-ID: <20210831203732.3411134-4-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210831203732.3411134-1-michaelba@nvidia.com> References: <20210831203732.3411134-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9b88441-8454-4050-a2ee-08d96cbf3a85 X-MS-TrafficTypeDiagnostic: PH0PR12MB5417: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aIvdZVa3StNpJn6YMgk28V4c3ohXh3WAmNKHu3trNXKw8v7JKBMSiqzFeLIK+S/Xyhps2i+wnyI8HTuXHdByYeKy3kiOoegQjVUvCtM3a6Q4ru00GXjvo3hMWzrbg+Fo5ORtXNi3NOweCUY3j1WRlhNq1LTLXtz7GUeFEgGKtH5wmDUSdAtNj53nuQgCL3WUmCVPW9EOJLSDr2+oMFfKxeYJTGne2pNk75hScFgOf4jAfN3rVI80XGx+utBBsCgmBSkVGapNuFUDvWdVTyFfcYFIiZ4E7+ZFzx1d88K0UBS1HH4oLVaDv1v5Al19qbAiIt58pMo/WM5eG83QdC0uwpIYogPuAB9fyfkJE+iCHpMD5+jc6/lDFs456fNCaOY7NfAu36BKy54ukqPzwKXle9QnSmiq0SibBKi9uFvzLXNyIZZAMOkuvU8Yevs60WJq2Svyen97TcRGG1vufXkDN+IW8mHEb6BtZkzr+SrKs6OSMY1edtiX6+SrqZdywLXi3pv1N2qpWpZoIaf17k+2Y2ebyG3SETk0K9hy0sEpBpFCzdbVI45lYnjpMTJt1MN3ksmSeyHWWxkx9fzA+fH//BbdETVsWahvlYh2hm04mtIg1YcpJB0N1i180ELxJd/7Ecc1q9STvGPcoDHYFPwrPthDgcN9PwfSxFc2he0entfhNp1eKm3i0fC5vEmlFf3//vHU/WJepVi9kIr3cAObCA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(6666004)(36906005)(55016002)(8936002)(82310400003)(36756003)(508600001)(54906003)(8676002)(426003)(70206006)(86362001)(6916009)(6286002)(356005)(450100002)(1076003)(47076005)(2906002)(36860700001)(7696005)(4326008)(2616005)(83380400001)(186003)(16526019)(336012)(5660300002)(7636003)(316002)(26005)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 20:38:02.4376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9b88441-8454-4050-a2ee-08d96cbf3a85 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5417 Subject: [dpdk-dev] [PATCH 3/6] net/mlx5: fix allow duplicate pattern devarg default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' was introduced. The default is to allow, and it is initialized to 1 in PCI probe function. However, on auxiliary bus probing (for Sub-Function) it is not initialized at all, so it's actually initialized to 0 Move the initialization to default config function which is called from both. Fixes: 919488fbfa71 ("net/mlx5: support Sub-Function") Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 3d204f99f7..cf4de7e6f9 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -2142,6 +2142,7 @@ mlx5_os_config_default(struct mlx5_dev_config *config) config->dv_flow_en = 1; config->decap_en = 1; config->log_hp_size = MLX5_ARG_UNSET; + config->allow_duplicate_pattern = 1; } /** @@ -2564,7 +2565,6 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev, /* Default configuration. */ mlx5_os_config_default(&dev_config); dev_config.vf = dev_config_vf; - dev_config.allow_duplicate_pattern = 1; list[i].numa_node = pci_dev->device.numa_node; list[i].eth_dev = mlx5_dev_spawn(&pci_dev->device, &list[i],