From patchwork Tue Aug 31 20:37:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 97642 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FBC9A0C58; Tue, 31 Aug 2021 22:38:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F064C41154; Tue, 31 Aug 2021 22:38:11 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2051.outbound.protection.outlook.com [40.107.237.51]) by mails.dpdk.org (Postfix) with ESMTP id 89F784113F; Tue, 31 Aug 2021 22:38:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=euCeKIND/1lmBkPac6+xpaJU6EEo092oYbJsBqZ8Xk+698pH1VbrbeKHx2VWL1lbZzwWj1BurG04zl/3RMfj4r5COwv0bo3AGaj3FSaOgJIek00fXvqYZoQ3WfCnmDjvgtgLwka1dHLApI4swnMeOZBKbMrBNxQHW8Iq1IhyUGGaHdL94KWl0qK1/s4Ty+dbwQq4VSOZ9QcnKuNdc7iEnBrFDkG+YE4dPd3/OaO6zZh/gZ4DCPE/LLy0vNuCFiBSbY6zHdaZlHUKfMc5qWuDyaUT2rxrkGYprvlGDuhoMQADq2z6opiQ9XDP2stU7QggpXxzO1npRTSTfcOgrwGLHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cZ9wdBf7CO9HLkJakwQcUzFgEzrgVi+OzLd0iPUD0Sg=; b=iRSLUQsZlrClV9MUvsrSXWJ/pjsjWZ8TM+BiLVASBg67AYonvHdEDtiJTGITWpfHTvvtsQHPtCzfysqwqJUQxPsSoVabwcA84xuFRoCweUu2z9Jj7dBPuKAYxHVRhXgyfsRiGGO9IxBDjt/AlSi1Mv5QuzfMasf3FcpTlWGp1JVWeeeJ4idDRuBISYOkzq+WFuWSPu6IN7oPcHq4Ww07OkM/BWiqTC4CbxtG4K5DLI7eMSpppYeWjgc2YNjxt7TQqrx2FCrpnkZAEb+/Vkbj7b0n8KUBZNl7FvSzSdL7A143a2XORydhwLFVOmcRnkZiyd/dSdap6UO1w2XP12HMUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cZ9wdBf7CO9HLkJakwQcUzFgEzrgVi+OzLd0iPUD0Sg=; b=dwrY3DPbEuq9uaMPxKUM1uk50CqqRebfu0x9JDBnzBnJTcbn7IgaEvmhRYQs8M6J/4TfNElnL0aBnC3Wuh4CMjX/tB/0RY8zYOSveVGk6s30sfMK5is2t35iwShTEkZVnv1GGiY/uFMLidSNAGTHfulFamWuzw+w8oHXwiCqIk44fhgIIjPNtMJiqbjHuafirgace3UzYhKKdNtKoOSiL81VDS3ithE1o/clbvSeIkLsdlY9SrseBYxL+xwDnfvL1buhnRiw/KzTjFuAXnZ2Dh08+XxmWICobh0w4Kxl00vikVsjh8ZuWlF1NyjFbZMRHp6HHJ86LIXN3piCgcy5mQ== Received: from BN9PR03CA0870.namprd03.prod.outlook.com (2603:10b6:408:13d::35) by DM5PR1201MB0217.namprd12.prod.outlook.com (2603:10b6:4:54::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Tue, 31 Aug 2021 20:38:08 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13d:cafe::c2) by BN9PR03CA0870.outlook.office365.com (2603:10b6:408:13d::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21 via Frontend Transport; Tue, 31 Aug 2021 20:38:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 31 Aug 2021 20:38:07 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 20:38:05 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug 2021 20:38:03 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Tue, 31 Aug 2021 23:37:31 +0300 Message-ID: <20210831203732.3411134-6-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210831203732.3411134-1-michaelba@nvidia.com> References: <20210831203732.3411134-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09ff88f3-7f9a-4602-e794-08d96cbf3dca X-MS-TrafficTypeDiagnostic: DM5PR1201MB0217: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NPgmSbCdHgLex6tsw5GKMDvBhM9WlvmQq0l/oeRVeWtCW7je1yhY7mZHZAm5dRdDb/u4Ose6La4uM8FiOnrzsoLS4dJgwNguLH1odCoK4OrAuf11H0AFJTXhrkxGKuVH2HpmvhMHXpFimuLCTDYVXYDj5Hzz3WX/FLShBFqYDmRVkWxVSu0HiEjxrCHdFpd1iJAuBw5VMU0bn2wS+F5H09b2saMSGXH1dHIFAhD2r2+NbNQjPUcS1/w5u9wHE8KKLjel6JN7QYGSckrpG4+yJYv0GR+GCgZgYWVd0Ld64/sN4NSA3FtKL68KYdJM2jtKCn5eRIDP28iEZamS+Jx+SMBtFaWnwjtCbIcjTb2mQ9iu5ZRumnEeD+etO8Zg0eKsefwIlv0CE9qRV68lRfG0C82xIv5SWgtkHOLnfIVYVEOglihpizPKmUI9yqvzQx08nLo0/fsknXgwRTH0OmGSL1iEsdO+85lZL5Id2JJx4RN1y75lEFLejXcy9w185ZS7+NWiG+yGjM8UQE+7GjoZ02lZqtrzE17a0CCaOAcxN1bVwEQhRcCTlj/zcgFi6xgzu4gzckFei+Rx86betP4LlKvkXsFH0PDWk7gttwzoLXxKtdDfiC+GlHevt/oSVn5QCFs3gx8xrM2mIAQBMFuQqFQCmidRajbRqHppLjsQqcPevIlj1aO24yf+wBgef6rQiOM3Q5E+eNYuvYBDvbheog== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid04.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(36840700001)(46966006)(8936002)(6916009)(6286002)(6666004)(47076005)(4326008)(450100002)(36860700001)(36756003)(426003)(186003)(1076003)(336012)(2906002)(2616005)(26005)(83380400001)(86362001)(478600001)(8676002)(7696005)(316002)(7636003)(5660300002)(82740400003)(356005)(70586007)(70206006)(16526019)(36906005)(55016002)(82310400003)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 20:38:07.9257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09ff88f3-7f9a-4602-e794-08d96cbf3dca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0217 Subject: [dpdk-dev] [PATCH 5/6] common/mlx5: fix device list operation concurrency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The MLX5 common driver has a global list of mlx5 devices which are probed. In probe function it create one and insert it to the list. Similarly it removes the device in remove function. These operations are not safe as there can be such operations in parallel, by different threads. Add global lock for the list and use it to insert or remove. Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class drivers") Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_common.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c index f6e440dca1..4321cb3a9c 100644 --- a/drivers/common/mlx5/mlx5_common.c +++ b/drivers/common/mlx5/mlx5_common.c @@ -50,6 +50,7 @@ static TAILQ_HEAD(mlx5_drivers, mlx5_class_driver) drivers_list = /* Head of devices. */ static TAILQ_HEAD(mlx5_devices, mlx5_common_device) devices_list = TAILQ_HEAD_INITIALIZER(devices_list); +static pthread_mutex_t devices_list_lock; static const struct { const char *name; @@ -222,7 +223,9 @@ mlx5_dev_to_pci_str(const struct rte_device *dev, char *addr, size_t size) static void dev_release(struct mlx5_common_device *dev) { + pthread_mutex_lock(&devices_list_lock); TAILQ_REMOVE(&devices_list, dev, next); + pthread_mutex_unlock(&devices_list_lock); rte_free(dev); } @@ -315,7 +318,9 @@ mlx5_common_dev_probe(struct rte_device *eal_dev) if (!dev) return -ENOMEM; dev->dev = eal_dev; + pthread_mutex_lock(&devices_list_lock); TAILQ_INSERT_HEAD(&devices_list, dev, next); + pthread_mutex_unlock(&devices_list_lock); new_device = true; } /* @@ -440,6 +445,7 @@ mlx5_common_init(void) if (mlx5_common_initialized) return; + pthread_mutex_init(&devices_list_lock, NULL); mlx5_glue_constructor(); mlx5_common_driver_init(); mlx5_common_initialized = true;