diff mbox series

[v3] net/ixgbe: fix mbuf leak

Message ID 20210901072237.9451-1-chenqiming_huawei@163.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v3] net/ixgbe: fix mbuf leak |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing fail Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Qiming Chen Sept. 1, 2021, 7:22 a.m. UTC 
  A local test found that repeated port start and stop operations during
the continuous SSE vector bufflist receiving process will cause the mbuf
resource to run out. The final positioning is when the port is stopped,
the mbuf of the pkt_first_seg pointer is not released. Resources leak.
The patch scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
---
v2:
  Sync to stable@dpdk.org
v3:
  Modify fixes commit
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Wang, Haiyue Sept. 6, 2021, 1:22 a.m. UTC | #1 
> -----Original Message-----
> From: Qiming Chen <chenqiming_huawei@163.com>
> Sent: Wednesday, September 1, 2021 15:23
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen <chenqiming_huawei@163.com>; stable@dpdk.org
> Subject: [PATCH v3] net/ixgbe: fix mbuf leak
> 
> A local test found that repeated port start and stop operations during
> the continuous SSE vector bufflist receiving process will cause the mbuf
> resource to run out. The final positioning is when the port is stopped,
> the mbuf of the pkt_first_seg pointer is not released. Resources leak.
> The patch scheme is to judge whether the pointer is empty when the port
> is stopped, and release the corresponding mbuf if it is not empty.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> v2:
>   Sync to stable@dpdk.org
> v3:
>   Modify fixes commit
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Haiyue Wang <haiyue.wang@intel.com>


> 
> --
> 2.30.1.windows.1
Qi Zhang Sept. 6, 2021, 1:45 a.m. UTC | #2 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Monday, September 6, 2021 9:22 AM
> To: Qiming Chen <chenqiming_huawei@163.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak
> 
> > -----Original Message-----
> > From: Qiming Chen <chenqiming_huawei@163.com>
> > Sent: Wednesday, September 1, 2021 15:23
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen
> > <chenqiming_huawei@163.com>; stable@dpdk.org
> > Subject: [PATCH v3] net/ixgbe: fix mbuf leak
> >
> > A local test found that repeated port start and stop operations during
> > the continuous SSE vector bufflist receiving process will cause the
> > mbuf resource to run out. The final positioning is when the port is
> > stopped, the mbuf of the pkt_first_seg pointer is not released. Resources
> leak.
> > The patch scheme is to judge whether the pointer is empty when the
> > port is stopped, and release the corresponding mbuf if it is not empty.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> > ---
> > v2:
> >   Sync to stable@dpdk.org
> > v3:
> >   Modify fixes commit
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> >
> > --
> > 2.30.1.windows.1
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index c814a28cb4..bfdfd5e755 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2981,6 +2981,10 @@  ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
 	rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);
 	rxq->rx_tail = 0;
 	rxq->nb_rx_hold = 0;
+
+	if (rxq->pkt_first_seg != NULL)
+		rte_pktmbuf_free(rxq->pkt_first_seg);
+
 	rxq->pkt_first_seg = NULL;
 	rxq->pkt_last_seg = NULL;