diff mbox series

[v2] vhost: add log print of socket path on adding connection

Message ID 20210907005127.89-1-gaoxiangliu0@163.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series [v2] vhost: add log print of socket path on adding connection | expand

Checks

Context Check Description
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK

Commit Message

Gaoxiang Liu Sept. 7, 2021, 12:51 a.m. UTC
Add log print of socket path in vhost_user_add_connection.
It's useful when adding a mass of socket connections,
because the information of every connection is clearer.

Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: stable@dpdk.org

Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
---
 lib/vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xia, Chenbo Sept. 7, 2021, 1:35 a.m. UTC | #1
> -----Original Message-----
> From: Gaoxiang Liu <gaoxiangliu0@163.com>
> Sent: Tuesday, September 7, 2021 8:51 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
> stable@dpdk.org
> Subject: [PATCH v2] vhost: add log print of socket path on adding connection
> 
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is clearer.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> ---
>  lib/vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index d6f9414c4..c6548608a 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
> *vsocket)
>  			dev->async_copy = 1;
>  	}
> 
> -	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
> +	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
> vsocket->path);
> 
>  	if (vsocket->notify_ops->new_connection) {
>  		ret = vsocket->notify_ops->new_connection(vid);
> --
> 2.32.0
> 

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Maxime Coquelin Sept. 14, 2021, 11:30 a.m. UTC | #2
On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> Add log print of socket path in vhost_user_add_connection.
> It's useful when adding a mass of socket connections,
> because the information of every connection is clearer.
> 
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> ---
>  lib/vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Applied to dpdk-next-virtio/main.

Thanks,
Maxime
Ferruh Yigit Sept. 16, 2021, 12:28 p.m. UTC | #3
On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> 
> 
> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>> Add log print of socket path in vhost_user_add_connection.
>> It's useful when adding a mass of socket connections,
>> because the information of every connection is clearer.
>>
>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>> ---
>>  lib/vhost/socket.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> 
> Applied to dpdk-next-virtio/main.
> 


Hi Gaoxiang,

I can see you are in the git history as:
"Gaoxiang Liu <liugaoxiang@huawei.com>"

Since we are trying to keep unique identity in the git history, I will use the
one in the git history. Please let us know if that is problem.

And is there any specific reason to use two different emails?

Thanks,
ferruh
Maxime Coquelin Sept. 16, 2021, 12:33 p.m. UTC | #4
On 9/16/21 14:28, Ferruh Yigit wrote:
> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>>
>>
>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>>> Add log print of socket path in vhost_user_add_connection.
>>> It's useful when adding a mass of socket connections,
>>> because the information of every connection is clearer.
>>>
>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>>> ---
>>>   lib/vhost/socket.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>>
>> Applied to dpdk-next-virtio/main.
>>
> 
> 
> Hi Gaoxiang,
> 
> I can see you are in the git history as:
> "Gaoxiang Liu <liugaoxiang@huawei.com>"
> 
> Since we are trying to keep unique identity in the git history, I will use the
> one in the git history. Please let us know if that is problem.

I fixed up the Author field in my pull request to match the SoB.
Did I miss something?

Thanks,
Maxime

> And is there any specific reason to use two different emails?


> Thanks,
> ferruh
>
Xia, Chenbo Sept. 16, 2021, 12:37 p.m. UTC | #5
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, September 16, 2021 8:33 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on
> adding connection
> 
> 
> 
> On 9/16/21 14:28, Ferruh Yigit wrote:
> > On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> >>
> >>
> >> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> >>> Add log print of socket path in vhost_user_add_connection.
> >>> It's useful when adding a mass of socket connections,
> >>> because the information of every connection is clearer.
> >>>
> >>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> >>> ---
> >>>   lib/vhost/socket.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>
> >>
> >> Applied to dpdk-next-virtio/main.
> >>
> >
> >
> > Hi Gaoxiang,
> >
> > I can see you are in the git history as:
> > "Gaoxiang Liu <liugaoxiang@huawei.com>"
> >
> > Since we are trying to keep unique identity in the git history, I will use
> the
> > one in the git history. Please let us know if that is problem.
> 
> I fixed up the Author field in my pull request to match the SoB.
> Did I miss something?

History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email,
So I told him to align and Maxime to fix when applying. Maybe it's my bad about not
being clear about which to use because it happens several times Gaoxiang uses two emails.

I notice people from Huawei sometimes use two emails for author and SOB tag.
So I have the same question :)

/Chenbo

> 
> Thanks,
> Maxime
> 
> > And is there any specific reason to use two different emails?
> 
> 
> > Thanks,
> > ferruh
> >
Ferruh Yigit Sept. 16, 2021, 12:57 p.m. UTC | #6
On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, September 16, 2021 8:33 PM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
>> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on
>> adding connection
>>
>>
>>
>> On 9/16/21 14:28, Ferruh Yigit wrote:
>>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>>>>
>>>>
>>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>>>>> Add log print of socket path in vhost_user_add_connection.
>>>>> It's useful when adding a mass of socket connections,
>>>>> because the information of every connection is clearer.
>>>>>
>>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>>>>> ---
>>>>>   lib/vhost/socket.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>
>>>>
>>>> Applied to dpdk-next-virtio/main.
>>>>
>>>
>>>
>>> Hi Gaoxiang,
>>>
>>> I can see you are in the git history as:
>>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
>>>
>>> Since we are trying to keep unique identity in the git history, I will use
>> the
>>> one in the git history. Please let us know if that is problem.
>>
>> I fixed up the Author field in my pull request to match the SoB.
>> Did I miss something?
> 
> History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email,
> So I told him to align and Maxime to fix when applying. Maybe it's my bad about not
> being clear about which to use because it happens several times Gaoxiang uses two emails.
> 

+1 to align SOB & author (I think checkpatch warns otherwise), but since in the
git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I think we
should align to that email address.

> I notice people from Huawei sometimes use two emails for author and SOB tag.
> So I have the same question :)
> 
> /Chenbo
> 
>>
>> Thanks,
>> Maxime
>>
>>> And is there any specific reason to use two different emails?
>>
>>
>>> Thanks,
>>> ferruh
>>>
>
Xia, Chenbo Sept. 16, 2021, 1:16 p.m. UTC | #7
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Thursday, September 16, 2021 8:57 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Gaoxiang Liu <gaoxiangliu0@163.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path
> on adding connection
> 
> On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
> >> -----Original Message-----
> >> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> >> Sent: Thursday, September 16, 2021 8:33 PM
> >> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
> >> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
> >> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas
> Monjalon
> >> <thomas@monjalon.net>
> >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket
> path on
> >> adding connection
> >>
> >>
> >>
> >> On 9/16/21 14:28, Ferruh Yigit wrote:
> >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> >>>>
> >>>>
> >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> >>>>> Add log print of socket path in vhost_user_add_connection.
> >>>>> It's useful when adding a mass of socket connections,
> >>>>> because the information of every connection is clearer.
> >>>>>
> >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >>>>> Cc: stable@dpdk.org
> >>>>>
> >>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> >>>>> ---
> >>>>>   lib/vhost/socket.c | 2 +-
> >>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>
> >>>>
> >>>> Applied to dpdk-next-virtio/main.
> >>>>
> >>>
> >>>
> >>> Hi Gaoxiang,
> >>>
> >>> I can see you are in the git history as:
> >>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
> >>>
> >>> Since we are trying to keep unique identity in the git history, I will
> use
> >> the
> >>> one in the git history. Please let us know if that is problem.
> >>
> >> I fixed up the Author field in my pull request to match the SoB.
> >> Did I miss something?
> >
> > History is Gaoxiang uses @163 email to send patches but signed-off with
> @huawei email,
> > So I told him to align and Maxime to fix when applying. Maybe it's my
> bad about not
> > being clear about which to use because it happens several times Gaoxiang
> uses two emails.
> >
> 
> +1 to align SOB & author (I think checkpatch warns otherwise), but since
> in the
> git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I
> think we
> should align to that email address.

That's fixed when applying IIRC. If Gaoxiang can only use @163 email to send patch,
maybe we should always align to another one...Or it's annoying to fix every time.

/Chenbo

> 
> > I notice people from Huawei sometimes use two emails for author and SOB
> tag.
> > So I have the same question :)
> >
> > /Chenbo
> >
> >>
> >> Thanks,
> >> Maxime
> >>
> >>> And is there any specific reason to use two different emails?
> >>
> >>
> >>> Thanks,
> >>> ferruh
> >>>
> >
Gaoxiang Liu Sept. 16, 2021, 1:36 p.m. UTC | #8
Hi Chenbo,

    liugaoxiang@huawei.com and gaoxiangliu0@163.com both are my email addresses.
You can align to liugaoxiang@huawei.com or gaoxiangliu0@163.com when applying the patch.
    And the email address of  liugaoxiang@huawei.com now has only the permission to receive emails,
but not the permission to send emails, so I have to send patches with @163 email.


Thanks,
Gaoxiang




At 2021-09-16 21:16:11, "Xia, Chenbo" <chenbo.xia@intel.com> wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Thursday, September 16, 2021 8:57 PM
>> To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Gaoxiang Liu <gaoxiangliu0@163.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
>> <thomas@monjalon.net>
>> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path
>> on adding connection
>> 
>> On 9/16/2021 1:37 PM, Xia, Chenbo wrote:
>> >> -----Original Message-----
>> >> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> >> Sent: Thursday, September 16, 2021 8:33 PM
>> >> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
>> >> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> >> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas
>> Monjalon
>> >> <thomas@monjalon.net>
>> >> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket
>> path on
>> >> adding connection
>> >>
>> >>
>> >>
>> >> On 9/16/21 14:28, Ferruh Yigit wrote:
>> >>> On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
>> >>>>
>> >>>>
>> >>>> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
>> >>>>> Add log print of socket path in vhost_user_add_connection.
>> >>>>> It's useful when adding a mass of socket connections,
>> >>>>> because the information of every connection is clearer.
>> >>>>>
>> >>>>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> >>>>> Cc: stable@dpdk.org
>> >>>>>
>> >>>>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
>> >>>>> ---
>> >>>>>   lib/vhost/socket.c | 2 +-
>> >>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>>>
>> >>>>
>> >>>>
>> >>>> Applied to dpdk-next-virtio/main.
>> >>>>
>> >>>
>> >>>
>> >>> Hi Gaoxiang,
>> >>>
>> >>> I can see you are in the git history as:
>> >>> "Gaoxiang Liu <liugaoxiang@huawei.com>"
>> >>>
>> >>> Since we are trying to keep unique identity in the git history, I will
>> use
>> >> the
>> >>> one in the git history. Please let us know if that is problem.
>> >>
>> >> I fixed up the Author field in my pull request to match the SoB.
>> >> Did I miss something?
>> >
>> > History is Gaoxiang uses @163 email to send patches but signed-off with
>> @huawei email,
>> > So I told him to align and Maxime to fix when applying. Maybe it's my
>> bad about not
>> > being clear about which to use because it happens several times Gaoxiang
>> uses two emails.
>> >
>> 
>> +1 to align SOB & author (I think checkpatch warns otherwise), but since
>> in the
>> git there are commits from 'Gaoxiang Liu <liugaoxiang@huawei.com>', I
>> think we
>> should align to that email address.
>
>That's fixed when applying IIRC. If Gaoxiang can only use @163 email to send patch,
>maybe we should always align to another one...Or it's annoying to fix every time.
>
>/Chenbo
>
>> 
>> > I notice people from Huawei sometimes use two emails for author and SOB
>> tag.
>> > So I have the same question :)
>> >
>> > /Chenbo
>> >
>> >>
>> >> Thanks,
>> >> Maxime
>> >>
>> >>> And is there any specific reason to use two different emails?
>> >>
>> >>
>> >>> Thanks,
>> >>> ferruh
>> >>>
>> >
>
diff mbox series

Patch

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index d6f9414c4..c6548608a 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -243,7 +243,7 @@  vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
 			dev->async_copy = 1;
 	}
 
-	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
+	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid, vsocket->path);
 
 	if (vsocket->notify_ops->new_connection) {
 		ret = vsocket->notify_ops->new_connection(vid);