From patchwork Tue Sep 14 08:35:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjun Wu X-Patchwork-Id: 98843 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8438FA0C46; Tue, 14 Sep 2021 10:54:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD25D410F5; Tue, 14 Sep 2021 10:53:59 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DDCE2410E8; Tue, 14 Sep 2021 10:53:56 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="220053127" X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="220053127" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 01:53:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="507768230" Received: from wuwenjun.sh.intel.com ([10.67.110.178]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2021 01:53:55 -0700 From: Wenjun Wu To: dev@dpdk.org, qi.z.zhang@intel.com Cc: Wenjun Wu , stable@dpdk.org Date: Tue, 14 Sep 2021 16:35:13 +0800 Message-Id: <20210914083513.341438-3-wenjun1.wu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210914083513.341438-1-wenjun1.wu@intel.com> References: <20210914083513.341438-1-wenjun1.wu@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v1 2/2] net/iavf: fix RSS configuration failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Due to share code limitation, when RSS for IP packets and IP fragment packets coexists, they cannot share the same hash field. As a result, independent configuration of default RSS for IP fragment packets need to be removed. This patch revert the original patch to fix this failure. Fixes: c40525568480 ("net/iavf: fix default RSS hash for IP fragment packets") Fixes: 9e29a278bc0c ("net/iavf: support default RSS for IP fragment") Cc: stable@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_hash.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index eba55ecea5..03dae5d999 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -623,16 +623,6 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) iavf_add_del_rss_cfg(ad, &rss_cfg, add); } - if (rss_hf & ETH_RSS_FRAG_IPV4) { - rss_cfg.proto_hdrs = outer_ipv4_tmplt; - iavf_add_del_rss_cfg(ad, &rss_cfg, add); - } - - if (rss_hf & ETH_RSS_FRAG_IPV6) { - rss_cfg.proto_hdrs = outer_ipv6_tmplt; - iavf_add_del_rss_cfg(ad, &rss_cfg, add); - } - vf->rss_hf = rss_hf & IAVF_RSS_HF_ALL; return 0; }